Skip to content

Conics #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Conics #900

wants to merge 8 commits into from

Conversation

benjamaan476
Copy link
Contributor

@benjamaan476 benjamaan476 commented Jun 24, 2025

Adds conic section sketch support along with helper functions for the conic types, hyperbolic, parabolic and elliptic.

Also adds helper functions that will return the point on a conic based on the coefficinents provided

@benjamaan476 benjamaan476 self-assigned this Jun 24, 2025
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@19ea8e4). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #900   +/-   ##
=======================================
  Coverage        ?   27.29%           
=======================================
  Files           ?       32           
  Lines           ?     1645           
  Branches        ?        0           
=======================================
  Hits            ?      449           
  Misses          ?     1196           
  Partials        ?        0           
Flag Coverage Δ
unittests 27.29% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

relative: bool,
},

///Adds a generic conic section specfied by the end point, interior point and tangents at the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI checks spelling.

Suggested change
///Adds a generic conic section specfied by the end point, interior point and tangents at the
///Adds a generic conic section specified by the end point, interior point and tangents at the

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants