fix: remove duplicate upsertApiConfiguration call causing profile state sharing #4094
+0
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…tate sharing When editing profile B while profile A is active, the handleSubmit function had a duplicate block that was: 1. Sending updateCondensingPrompt twice (line 560 and removed duplicate) 2. Sending upsertApiConfiguration to currentApiConfigName (active profile A) instead of editingApiConfigName (profile B being edited) 3. Sending telemetrySetting twice (line 564 and removed duplicate) The duplicate upsertApiConfiguration call caused both profiles to receive identical configuration when saving, explaining the bug where 'change B, then A gets the same changes'. The duplicate code block appears to be leftover from before PR #3732's profile isolation changes, likely kept during the merge in PR #3895. Fixes the profile state sharing bug reported after PR #3895 merge.
markijbema
force-pushed
the
mark/fix-profile-state-sharing-bug
branch
from
96c60c2 to
02262d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When editing profile B while profile A is active, the
handleSubmitfunction inSettingsView.tsxwas sendingupsertApiConfigurationto BOTH profiles:editingApiConfigName(profile B) ✅currentApiConfigName(profile A) ❌This caused both profiles to receive identical configuration when saving, explaining the bug where "change B, then A gets the same changes".
Root Cause
The duplicate code block appears to be leftover from before PR #3732's profile isolation changes, likely kept during the merge in PR #3895 (Include changes from Roo Code v3.30.1-v3.32.0).
Fix
Remove the duplicate
upsertApiConfigurationcall that was incorrectly saving tocurrentApiConfigNameinstead ofeditingApiConfigName.Related