-
Notifications
You must be signed in to change notification settings - Fork 39
Improve Zstd binary provided #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
That progress bar is slick! I think the result page should show the ratio inverted
I was also wondering if it might make sense to make this repo a cargo workspace and put the zstd binary into it's onw crate? This might make dependency management and crate features less messy |
I agree that the ratio feels inverted, but it's how Facebook represents it (and I think most entities). It could be replaced with https://facebook.github.io/zstd/ Switching to a workspace makes sense, I'd be down for that and can implement that change if needed. |
The C-based zstd utility outputs the compression ratio as a percentage:
|
That would be awesome!
I think that's just for benchmarking purposes (or rather for purposes of cool graphs). "Line go up" is visually more impressive than "Line go down". Since the C impl seem to show this as a precentage then that's the way I'd go too :) |
Okay, switching to a workspace has been done, and the ratio was switched to a percentage (as well as a more granular time display) Some future discussion topics:
|
Closes #38
This PR introduces the addition of several crates to improve the ergonomics of the CLI.
The new CLI has been designed to be simple, ergonomic, and scale well as more features are added. It has a real time progress bar, along with an ETA. Once processing is complete, it presents basic stats about what happened.
If demand is present, backwards compatibility could be added under a
compat
subcommand.Future work building on this PR might involve the addition of a
bench
subcommand, and/or agen-dict
subcommand.Attached is a recording of the
decompress
command in action