Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove defaultprops #137

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

CristianDeluxe
Copy link
Contributor

Since defaultprops is going to be deprecated, these changes eliminate its use and use the javascript default params.

Warning: AdvertisingSlot: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.

Took 7 minutes
@CristianDeluxe CristianDeluxe requested a review from a team as a code owner June 21, 2024 17:19
@CristianDeluxe CristianDeluxe requested review from masonbraun and thedaviddias and removed request for a team June 21, 2024 17:19
Copy link
Contributor

@caffeinated-pixels caffeinated-pixels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response. Looks good, thanks for the contribution!

@caffeinated-pixels caffeinated-pixels changed the title Remove defaultprops fix: remove defaultprops Jul 10, 2024
@caffeinated-pixels caffeinated-pixels merged commit 7771da4 into KijijiCA:master Jul 10, 2024
2 of 3 checks passed
thedaviddias pushed a commit that referenced this pull request Jul 10, 2024
## [4.2.12](v4.2.11...v4.2.12) (2024-07-10)

### Bug Fixes

* remove defaultprops ([#137](#137)) ([7771da4](7771da4))
@thedaviddias
Copy link
Member

🎉 This PR is included in version 4.2.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@CristianDeluxe
Copy link
Contributor Author

Thank you guys! 🫶

CristianDeluxe pushed a commit to BusiRocket/react-advertising that referenced this pull request Jul 10, 2024
## [4.2.12](KijijiCA/react-advertising@v4.2.11...v4.2.12) (2024-07-10)

### Bug Fixes

* remove defaultprops ([KijijiCA#137](KijijiCA#137)) ([7771da4](KijijiCA@7771da4))


Took 4 minutes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants