Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Adding USB3250 UTMI PHY #2419

Merged
merged 3 commits into from
May 31, 2020
Merged

Adding USB3250 UTMI PHY #2419

merged 3 commits into from
May 31, 2020

Conversation

ki5libs
Copy link
Contributor

@ki5libs ki5libs commented Jan 2, 2020

Adding USB3250 UTMI PHY
Datasheet

USB3250

Footprint PR


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@chschlue chschlue added Addition Adds new symbols to library Pending footprint Pending footprint acceptance before merging Pending reviewer A pull request waiting for a reviewer labels Jan 2, 2020
@evanshultz
Copy link
Collaborator

Footprint is now merged.

@ki5libs ki5libs closed this Jan 6, 2020
@ki5libs ki5libs reopened this Jan 6, 2020
@myfreescalewebpage myfreescalewebpage self-assigned this Apr 1, 2020
@myfreescalewebpage myfreescalewebpage removed Pending footprint Pending footprint acceptance before merging Pending reviewer A pull request waiting for a reviewer labels Apr 1, 2020
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Apr 1, 2020

Hi @ki5libs , thanks for contributing,

A few comments I have during my review:

  • Datasheet link is not correct, should be http://ww1.microchip.com/downloads/en/DeviceDoc/00002142A.pdf
  • Description should ends with package name: Hi-Speed USB Device Transceiver with UTMI Interface, QFN-56
  • Footprint filter should be: QFN*1EP*8x8mm*P0.5mm*
  • XO should be Output
  • RBIAD should be Passive

Cheers,
Joel

@myfreescalewebpage
Copy link
Collaborator

@ki5libs ping

@ki5libs
Copy link
Contributor Author

ki5libs commented May 29, 2020

Hi @myfreescalewebpage sorry for delay, I've missed that for some reason. It's fixed now. Thanks for review!

@myfreescalewebpage
Copy link
Collaborator

Thanks, no worries! No more comment, merging.

@myfreescalewebpage myfreescalewebpage merged commit 62eaeb8 into KiCad:master May 31, 2020
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.7 milestone Jun 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants