This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9a1d071
to
45a358f
Compare
5 tasks
The connector lib is for generic symbols of different connector types. I suspect that there will be similar parts out there so my suggestion would be to remove the datasheet and footprint assignment. Set the footprint filter to fit the prefix of the footprint and rename the symbol to CoaxialSwitch_Testpoint (or similar) Alternative we make a specialized lib for things like that and have fully specified symbols. I am however not convinced that this would be the right move at this point in KiCads development. |
remove datasheet and footprint relax footprint filter Signed-off-by: Ilias Daradimos <ilias@libre.space>
The footprint filter should be generic as well |
I think you misunderstood what i meant with "generic footprint filter". I would suggest to use the filter |
Signed-off-by: Ilias Daradimos <judgedrid@gmail.com>
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Hirose MS-156C3 rf testpoint
Datasheet https://www.hirose.com/product/document?clcode=CL0358-0340-0-00&productname=MS-156C3&series=MS-156C&documenttype=2DDrawing&lang=en&documentid=0000954375
Footprint: KiCad/kicad-footprints#1773

All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items: