Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add Hirose MS-156C3 rf testpoint #2068

Merged
merged 5 commits into from
Jul 7, 2020
Merged

Add Hirose MS-156C3 rf testpoint #2068

merged 5 commits into from
Jul 7, 2020

Conversation

drid
Copy link
Contributor

@drid drid commented Aug 10, 2019

Add Hirose MS-156C3 rf testpoint

Datasheet https://www.hirose.com/product/document?clcode=CL0358-0340-0-00&productname=MS-156C3&series=MS-156C&documenttype=2DDrawing&lang=en&documentid=0000954375

Footprint: KiCad/kicad-footprints#1773
image


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@cpresser cpresser added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Aug 14, 2019
@drid drid force-pushed the MS-156C3 branch 2 times, most recently from 9a1d071 to 45a358f Compare November 20, 2019 11:48
@poeschlr poeschlr self-assigned this Jan 7, 2020
@poeschlr poeschlr added Pending changes User is expected to perform fixes before merging and removed Pending reviewer A pull request waiting for a reviewer labels Jan 7, 2020
@poeschlr
Copy link
Collaborator

poeschlr commented Jan 7, 2020

The connector lib is for generic symbols of different connector types. I suspect that there will be similar parts out there so my suggestion would be to remove the datasheet and footprint assignment. Set the footprint filter to fit the prefix of the footprint and rename the symbol to CoaxialSwitch_Testpoint (or similar)

Alternative we make a specialized lib for things like that and have fully specified symbols. I am however not convinced that this would be the right move at this point in KiCads development.

drid added 2 commits January 9, 2020 13:42
remove datasheet and footprint
relax footprint filter

Signed-off-by: Ilias Daradimos <ilias@libre.space>
@poeschlr
Copy link
Collaborator

The footprint filter should be generic as well

@poeschlr poeschlr added Ready for review Use this to mark pull requests that are updated but you could not review instantly and removed Pending changes User is expected to perform fixes before merging labels Apr 26, 2020
@poeschlr
Copy link
Collaborator

I think you misunderstood what i meant with "generic footprint filter". I would suggest to use the filter CoaxialSwitch*

@poeschlr poeschlr added Pending changes User is expected to perform fixes before merging and removed Ready for review Use this to mark pull requests that are updated but you could not review instantly labels Jun 11, 2020
Signed-off-by: Ilias Daradimos <judgedrid@gmail.com>
@poeschlr
Copy link
Collaborator

poeschlr commented Jul 7, 2020

Thanks

@poeschlr poeschlr merged commit daef621 into KiCad:master Jul 7, 2020
@poeschlr poeschlr removed the Pending changes User is expected to perform fixes before merging label Jul 7, 2020
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.7 milestone Jul 7, 2020
@drid drid deleted the MS-156C3 branch July 7, 2020 10:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants