-
Notifications
You must be signed in to change notification settings - Fork 742
Conversation
Hi @jeanthom , thanks for contributing, A few comments I have during my review:
Cheers, |
I updated the symbol, to address most of your comments: I don't think I will be able to properly center my component as its center is not on a 100mil grid. Regarding BAT pin stacking, I read on KiCad's website that you can't do pin stacking with pin types other that Power input/Power output/Output. The battery pin is both a power input and output (this chip charges the battery, but also draws current from the battery). Should I keep the two BAT pins separate ? |
Rules for pin stacking are at http://kicad-pcb.org/libraries/klc/S4.3/ and do not specify that only Power pins are concerned. However, there is a special attention to Power pins due to ERC checks to not get errors. Exemple of similar device with correct pin stacking: LTC4156. Joel |
Hi @jeanthom thanks for the fixes. Several point not addresses yet. Additionally:
Cheers, |
Hi, I fixed the footprint filter, but I don't understand why VQFN-16-1EP_3x3mm_P0.5mm_EP1.68x1.68mm is not the right footprint. It seems to fit perfectly the datasheet's drawings: |
@jeanthom the EP size is not the same. 1.6mm <> 1.68mm, even if it is a small difference, a new footpritn should be created. |
Damn... Thanks for your perceptiveness, I will submit a footprint ASAP |
@jeanthom any news here about the footprint ? If you have created a footprint pull request, can you give the link here ? Thanks, Joel |
@jeanthom ping :) |
Should IN be on top and PGOOD and CHG not? My understanding of KLC (http://kicad-pcb.org/libraries/klc/) is that power pins are on top so perhaps the request above was asking to put the open drain pins at the top of a side, and not the top of the symbol? |
@evanshultz my request was to get open drain type on the right side yes, usually they are at the bottom of the right side in the library. |
Hi! Sorry for the delay, I was busy for the last couple of weeks. I haven't got time yet to create the footprint nor rework the symbol, I hope to get both done by the end of April. |
No worries @jeanthom your pull request remains open, take your time to do it :) Thanks for your message! |
Footprint has been proposed by another contributor: KiCad/kicad-footprints#1605 |
Thanks for the information, I think I did the needed changes to use this footprint. Let's hope that the CI goes right :) |
Thanks, looks great ! Just notice one of my previous comment is not correctly written:
Can you fix it please ? |
@jeanthom any news here ? Please also solve the branch conflict to continue. |
@jeanthom ping ! |
No news of the original author, indicate the PR is abandoned. |
Hi, |
Hello,
Here's a symbol for Texas Instrument's BQ24072 and BQ24073 battery charger ICs.
Datasheet
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items: