Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add 2 mm and 2.1 mm mounting holes #922

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

diegoherranz
Copy link
Collaborator

@diegoherranz diegoherranz commented Sep 8, 2018

Modified from other existing mounting holes.
Thanks.


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

Modified from other existing mounting holes.
@poeschlr
Copy link
Collaborator

poeschlr commented Sep 9, 2018

Which screws would fit these mounting holes?

@diegoherranz
Copy link
Collaborator Author

diegoherranz commented Sep 9, 2018

I needed this to be used with plastic locating pips on a moulded plastic part. So, it didn't make sense to mention any screw size.
I've seen there are many mounting holes on this library which only reference the actual hole size and no screw at all, leaving the decision to the user and I guess that's OK?
Thanks!

@poeschlr
Copy link
Collaborator

poeschlr commented Sep 9, 2018

I was mainly confused as i thought you might have intended these to be used for M2 screws.

@poeschlr
Copy link
Collaborator

poeschlr commented Dec 5, 2018

Thanks for your contribution and sorry it took so long.

@poeschlr poeschlr merged commit 1438595 into KiCad:master Dec 5, 2018
@diegoherranz
Copy link
Collaborator Author

Not a problem. The important thing is that it eventually gets merged.
Thanks again to the good work by the librarians.

@diegoherranz diegoherranz deleted the mounting_holes branch December 13, 2018 23:11
@myfreescalewebpage myfreescalewebpage added the Addition Adds new footprint to library label Mar 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants