Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Update TO-xxx stagger footprints #765

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

evanshultz
Copy link
Collaborator

It seems #574 had a few mistakes as I noted at #764.

This PR should correct all footprints. I checked this several times and checked all footprints, but I'm afraid I've gotten bleary-eyed or I didn't catch something in the nearly-indecipherable script that makes them wrong.

The impetus for this was to add the TO-220F-4 footprint missing that I noted at KiCad/kicad-symbols#765. See page 10 at https://www.fairchildsemi.com/datasheets/KA/KA5M0265R.pdf. I made both stagger configurations just for the heck of it.
image


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

@evanshultz
Copy link
Collaborator Author

Script update at pointhi/kicad-footprint-generator#151.

@poeschlr
Copy link
Collaborator

poeschlr commented Aug 29, 2018

The information this is based on was wrong. For some reason i used the pin furthest from the package as the reference for the lead lenght field instead of pin 1 as i originally wrote in the KLC. It might be better to document how it is done right now in the KLC instead of renaming all footprints. (This would allow us to include the lib changes in future bug fix releases of kicad.)
I also suspect that i had my reasons for changing my mind. (My guess is that there are some footprints where lead length does not make sense if it is calculated between pad 1 and nearest body outline)

I am sorry about the additional work this causes.

@evanshultz
Copy link
Collaborator Author

In some cases pin 1 could be under the body, and without a sign (plus/minus) on the Lead field there's no way to know this. Take http://www.ti.com/lit/ds/symlink/lm675.pdf but imagine the stagger pattern is opposite (swap near and far pin stagger). How to handle that? Would this require using the farthest lead from the body, then?

It's fine for me to do the work if we can devise a solid methodology. :)

@poeschlr
Copy link
Collaborator

Ah that would explain why i used the farthest pin as reference.
I would in that case really change the KLC to fit our current naming convention.

poeschlr added a commit to poeschlr/kicad-website that referenced this pull request Dec 31, 2018
- Documents the currently used rule (referencing always to pin 1 might
result in negative lenght in some vertical parts. Use furthest pin
instead.)
- See discussion in KiCad/kicad-footprints#765
poeschlr added a commit to poeschlr/kicad-website that referenced this pull request Dec 31, 2018
- Documents the currently used rule (referencing always to pin 1 might
result in negative lenght in some vertical parts. Use furthest pin
instead.)
- See discussion in KiCad/kicad-footprints#765
@poeschlr poeschlr closed this Dec 31, 2018
@poeschlr poeschlr reopened this Dec 31, 2018
@poeschlr
Copy link
Collaborator

I update the KLC in KiCad/kicad-website#367. This clarifies that the lead length is measured between the body and the pad furthest away.

Could you align the naming to this? (meaning revert the changes to the lead length)
Also note that i left the definition of x pitch unchanged to get the least disruptive change. (So the pitch is therefore defined as the distance between pads of the same row)

marekr pushed a commit to KiCad/kicad-website that referenced this pull request Dec 31, 2018
- Documents the currently used rule (referencing always to pin 1 might
result in negative lenght in some vertical parts. Use furthest pin
instead.)
- See discussion in KiCad/kicad-footprints#765
@poeschlr poeschlr self-assigned this Jan 1, 2019
@poeschlr poeschlr added Enhancement Improves existing footprint in the library Pending changes labels Jan 1, 2019
@evanshultz
Copy link
Collaborator Author

Yes, I'll get on this. Probably next week.

@CLAassistant
Copy link

CLAassistant commented Jun 29, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


evanshultz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@evanshultz evanshultz closed this Jul 1, 2019
@evanshultz evanshultz reopened this Jul 1, 2019
@poeschlr
Copy link
Collaborator

Is CLA broken? Or did you change your mail address that is connected to github?

@evanshultz
Copy link
Collaborator Author

No change in email address. Not sure what's going on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing footprint in the library Pending changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants