-
Notifications
You must be signed in to change notification settings - Fork 711
Update TO-xxx stagger footprints #765
base: master
Are you sure you want to change the base?
Conversation
Script update at pointhi/kicad-footprint-generator#151. |
The information this is based on was wrong. For some reason i used the pin furthest from the package as the reference for the lead lenght field instead of pin 1 as i originally wrote in the KLC. It might be better to document how it is done right now in the KLC instead of renaming all footprints. (This would allow us to include the lib changes in future bug fix releases of kicad.) I am sorry about the additional work this causes. |
In some cases pin 1 could be under the body, and without a sign (plus/minus) on the It's fine for me to do the work if we can devise a solid methodology. :) |
Ah that would explain why i used the farthest pin as reference. |
- Documents the currently used rule (referencing always to pin 1 might result in negative lenght in some vertical parts. Use furthest pin instead.) - See discussion in KiCad/kicad-footprints#765
- Documents the currently used rule (referencing always to pin 1 might result in negative lenght in some vertical parts. Use furthest pin instead.) - See discussion in KiCad/kicad-footprints#765
I update the KLC in KiCad/kicad-website#367. This clarifies that the lead length is measured between the body and the pad furthest away. Could you align the naming to this? (meaning revert the changes to the lead length) |
- Documents the currently used rule (referencing always to pin 1 might result in negative lenght in some vertical parts. Use furthest pin instead.) - See discussion in KiCad/kicad-footprints#765
Yes, I'll get on this. Probably next week. |
evanshultz seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Is CLA broken? Or did you change your mail address that is connected to github? |
No change in email address. Not sure what's going on. |
It seems #574 had a few mistakes as I noted at #764.
This PR should correct all footprints. I checked this several times and checked all footprints, but I'm afraid I've gotten bleary-eyed or I didn't catch something in the nearly-indecipherable script that makes them wrong.
The impetus for this was to add the TO-220F-4 footprint missing that I noted at KiCad/kicad-symbols#765. See page 10 at https://www.fairchildsemi.com/datasheets/KA/KA5M0265R.pdf. I made both stagger configurations just for the heck of it.
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items: