Add Inolux IN-PI554FCH footprint

[diegoherranz]

Started from LED_WS2812B_PLCC4_5.0x5.0mm_P3.2mm
but mark indicates pin 1 in this case whereas it
indicates pin 3 on the WS2812B.

New symbols at KiCad/kicad-symbols#766

---

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

• Provide a URL to a datasheet for the footprint(s) you are contributing
• An example screenshot image is very helpful
• If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
• Check the output of the Travis automated check scripts - fix any errors as required

[Misca1234]

Hi

What is the diagonal line under pad 3 ?
You do not have to mark pin 1 with the text "1" in the F.SilkS layer, it is already marked in F.Silk layer

[diegoherranz]

Thanks, @Misca1234, for your comments. You're right.

All this originates from the fact that this symbol was derived from WS2812B and that LED has a mark on pin 3 (who knows why).

I forgot to move the diagonal line on F.Fab to pin 1. Now fixed.
I guess there was a text field saying "1" on Silkscreen to reiterate that that is pin 1 and not the one with the diagonal marking. Since this Inolux LED has a "sane" marking (that is, pin 1 marked), it is not necessary to reiterate which pin is pin 1, so I've removed it.

Thanks!

[Misca1234]

Seems that LED_SMD library need some attention, for example
WS2812B: Have the pin "1" marker in silk and the "pin marker in silk layer" on wrong place (at pin 3)
LED_SK6812_PLCC4_5.0x5.0mm_P3.2mm: is rotated wrong

Could you just post a screen shoot of your new footprint ?

PS
Is it possible for you to move the F.Silk layer to be 0.12 outside the F.Fab lines ?
DS

Something like this

or something like this

or like this

[Shackmeister]

I recall something about the marker on the actually component being on pin 3. If you chwck the history of the footprint you can probably fint the discussion

[diegoherranz]

I've tightened up the silkscreen. Something like this?

Regarding WS2812B, I think it is all correct regarding Pin 1 vs Pin 3 because of the marker on the device being on pin 3! See the datasheet.
We could potentially do some cleaning/improving on a few SMD LEDs by the look of it.

Thanks!

[Misca1234]

@Shackmeister

I am not so sure about that, for this one, checkout the data sheet
http://www.inolux-corp.com/datasheet/SMDLED/Addressable%20LED/IN-PI554FCH.pdf

but for the 128 it seems that the pin marker is at pin 3
https://cdn-shop.adafruit.com/datasheets/WS2812B.pdf

[Misca1234]

@diegoherranz

The F.Fab pin marker should be a cut corner, like this

[diegoherranz]

I have cut the corner as requested.

Regarding pin 1 vs pin 3:

• Inolux LED (this PR): it has the marker on pin 1, and that is what's reflected here.
• WorldSemi WS2812B: it has the marker on pin 3 and that is what LED_WS2812B_PLCC4_5.0x5.0mm_P3.2mm reflects.

So I think it all looks OK in terms of pin 1 / pin 3 stuff. I guess some "style" improvements could be made on the WS2812B footprint (silkscreen, F.Fab...) but that's a separate story.

Thanks.

[diegoherranz]

Gentle reminder. Thanks.

[diegoherranz]

Thanks!