-
Notifications
You must be signed in to change notification settings - Fork 710
Conversation
Hey Duckle29, some questions/things:
|
@herostrat Hey :)
|
Hey, thanks for the update Just a heads-up, I am no maintainer so take everything with a grain of salt. But on the Github profile, their website and the shop and on some other hw revisions its all caps. I don't know if they are inconsitent, if they changed it or whatever. About the PTH design rules, I could be wrong with my statement. One other thing I thought about. Thanks for updating :) |
@herostrat wrote:
You seem to be quite interested in reviewing the work of others. So far your suggestions where not really wrong. (Some rules are not even known to us maintainers at every point in time. So even we make mistakes sometimes.) And regarding the "I am not a maintainer" comment: I can change that ;) Regarding the point about the center: Travis does however report that the reference is set to the wrong value. (looks like you started the footprint editor from within a pcb as it still has the reference A1. Change that to Ref** as suggested by our test script.) |
That's very nice for you to say.
That I didn't know. |
I don't know why this was a closed. Probably because I force merged my local branch to clean up some mess |
@poeschlr Hey I just wanted to give a heads-up that I got back to this after leaving it for quite a while :) |
@Duckle29 I suggest you skip the reserved area for the usb connector I am also somewhat sceptical to that you place the module already on those "https://c1.staticflickr.com/1/734/31400410271_f278b087db_z.jpg" If you want to absolutely sure you could send an email to wemos and ask them @herostrat |
Hey there, thanks for taking a look. I agree that there's a lot of different USB cables, but a lot of them should fit the crtyrd I have put into this foot-print. I am not a huge fan of how it looks though, and would like to see an official "modules" section added to the KLC, that deals with these sorts of questions :) As for dimensions, I have several different boards, both official from the manufacturer, and a lot of other boards from eBay and ali-express, they all fit the layout here. As for the keep-out, I mentioned that the most common of these boards, use the ESP8266MOD module. (mentioned that on the 3D model PR) Because of this, I can see what keep-out they have used themselves, directly under the antenna of the ESP8266MOD, and this is the same keep-out I have further put in my footprint. |
I am not sure this is the same use case as for your module. About the clearance of the antenna, from what I can see the radio module is ESP8285, which in turn means espressif and here is their recommended land patterns for their modules regarding the antenna They do have an option6 with no clearance area but all the others have 5 mm |
Ahh I see what you mean with clearance. Because of how the boards are made, they are actually already 10mm wider than the antenna (5mm on each side) so this is already implemented. As for the crtyrd, I'm not sure either. I'd very much like a verdict on it, or maybe a module-specific section in the KLC :) |
I think the CrtYd should not include the connector, because it is a completely arbitrary size. In other modules of the library there is also no CrtYd for them. @Misca1234 I also think WEMOS is the way to go :) |
Okay, thanks for clearing that up. I wasn't a huge fan of it either, as it looked wonky and made the PCB layout a bit messy. |
Nice, thank you very much. And you mentioning that it already worked in reallife is also a good indicator :) |
It is a tricky module. Also, are you sure that it is the mini and not mini lite you are doing ? If it is the mini lite, you need to change the name of the file to include lite (so others can make the mini one without name clashing) MiniLite: Mini: Which in turn would imply that the F.Fab and F.CrtYrd should just enclose the pin holes and make it possible to use the area beneath the module (keep the keep out area) ? What do you think about that ? |
I agree that it looks more like the lite board. and that it should be named as such. What had me confused is that the boards I have all have 4MB of flash, which is mini should have, however, I think that flash-size is more relevant for software. |
As for the holes and such. I do not agree that I should make cutouts for the USB plug or other such things, nor do I agree that the entire area underneath should be keep-out. If a designer wishes to place the device flush to the PCB, then that designer should know not to put any parts underneath, additionally, most boards bought on eBay and similar, have just the module on top, and then a lot of components on the bottom, meaning you run into the same issues as you would with the mini. The modules are meant to be plugged into headers. |
Just asking out of curiosity: how would you solder the d1 mini lite to the pcb directly? Imho it is meant to be used with pin-headers or even stack-able with a pin-socket on the pcb an headers on the wemos. At least I have only seen implementation like this (including one of mine) |
A note on silk following the contour. It's a visual guide to properly orient the wemos when inserting into PCB, something I've had to use quite a few times now :) |
Ok, but the F.Fab should follow the contour of the component |
@Duckle29 (module WEMOS_D1_mini_light (layer F.Cu) (tedit 5BB78BEF) |
@Misca1234 I like it, I'll push that to my fork |
Great, thx |
Now it is just one thing left from my side, please change the .step files for the 3D model to .wrl files You will get a bunch of new travis errors, but those will be ignored for the merge |
Note the Travis errors. The footprint file above has issues with the 3D model section. Image, which is helpful when visual changes have been made:
|
@evanshultz I will add the text when I get home, but the rule says it may be included, not that it has to be. As for 3D models, I'll change it to wrl if you want, but I thought it'd switch to step files with kicad 5.0? EDIT: And I will ofc fix typos |
Please do add the text. It makes it much more clear to users. 3D model references must be WRL. See http://kicad-pcb.org/libraries/klc/F9.3/. KiCad knows how to link STEP models automatically, I believe. |
@evanshultz Done :) |
Thanks! There's still a typo of "column" in the description. I can't recall ever seeing a footprint call multiple 3D models before. All your 3D models are at the default spacing and locations which definitely isn't correct. @poeschlr Can you take a look at this? |
@evanshultz Fixed the spelling error. This is how the 3D looks to me: I'm also curious to hear how to handle modules and their pin headers like this. |
Still a typo. There should be a "n" at the end of "column". Unless there is a precedent for having multiple 3D models, I think a unique, single 3D model for the entire module is best. Perhaps @poeschlr or @Shackmeister would know? |
I think the multiple 3D models is ok, I found it useful when I reworked the valves. @Duckle29 |
@Duckle29 |
Sorry for taking my time on this. Had some exams to focus on. Turns out that was stupid, as I already had fixed this, just forgotten to push |
Thx |
I would generally speaking go for one single model |
I have a (late question) because I just noticed the name. Why the "light" extension? We should rename it without "light" imho. See pinout the same for mini and mini light: |
Added a module for the WeMos D1 Mini. The large crtyd is to allow for a USB cable to be inserted into the wemos
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:
Dimensions of the board This is the best I could find.
Symbol PR KiCad/kicad-symbols#727