Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add footprint for E73-2G4M04S-52832 BLE5 module #555

Merged
merged 3 commits into from
May 18, 2018

Conversation

isundaylee
Copy link
Contributor

Datasheet: http://www.cdebyte.com/en/downpdf.aspx?id=243 (page 5)

Symbol PR: KiCad/kicad-symbols#573

Screenshot:

screen shot 2018-05-04 at 2 09 13 pm


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

@isundaylee
Copy link
Contributor Author

I centered the anchor with regards to F.Fab. However the CI seems to be complaining. Should I center it with regards to the copper pads instead?

@poeschlr
Copy link
Collaborator

poeschlr commented May 6, 2018

Is it on purpose that the pin numbers start at zero?

@isundaylee
Copy link
Contributor Author

@poeschlr I was following the pin number in the data sheet. Not clear why it is like that though.

@poeschlr
Copy link
Collaborator

poeschlr commented May 6, 2018

The drawing in the datasheet is over constrained. The part can not be both 17.5mm wide while the pads are 1.77mm from the side and the pin pitch is 1.27mm (1.2711+21.77 would be 17.51)

So either we assume that the 1.77mm measurement is rounded (should then be 1.765mm)
Or the with of the part is rounded (and should in reality be 17.51mm)

I would for the former and move all pads on the bottom row to the left by 0.005mm.

screenshot from 2018-05-06 11-47-49

@isundaylee
Copy link
Contributor Author

@poeschlr Thanks for the review! Changed as requested.

@evanshultz
Copy link
Collaborator

The pad fix above looks OK to me. Please rename this footprint to just E73-2G4M04S since it's compatible with both 52832 and 52810 versions. Then I think it's ready to merge!

@isundaylee
Copy link
Contributor Author

@evanshultz Thanks! Renamed as requested.

@evanshultz
Copy link
Collaborator

Thank you!

@evanshultz evanshultz merged commit 6005b86 into KiCad:master May 18, 2018
@myfreescalewebpage myfreescalewebpage added the Addition Adds new footprint to library label May 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants