Skip to content
This repository was archived by the owner on Oct 2, 2020. It is now read-only.

Create USB_C_Plug_JAE_DX07P024AJ1.kicad_mod #507

Closed
wants to merge 1 commit into from

Conversation

dsilwa
Copy link

@dsilwa dsilwa commented Apr 23, 2018

Footprint for JAE DX07P024AJ1 USB-C plug.
https://www.mouser.com/ds/2/206/MB-0301-2E_DX07_PLUG-890474.pdf
image


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

@CLAassistant
Copy link

CLAassistant commented Apr 23, 2018

CLA assistant check
All committers have signed the CLA.

@dsilwa dsilwa force-pushed the master branch 2 times, most recently from cad46d6 to 339dc2c Compare April 24, 2018 07:19
@Ratfink
Copy link
Collaborator

Ratfink commented May 7, 2018

Thanks for the contribution, and sorry for taking so long to review this. We've been discussing name changes of USB Type-C connectors that may affect this PR, but I can certainly review everything except the name in the meantime.

For footprints like this, proper placement of the anchor can be hard to determine. I'd suggest placing it aligned with the bottom-most PCB edge lines, on the "℄ OF 7.8 ±0.08" on the drawing.

The horizontal PCB edge segments under the shield pads should be 0.65 mm from the bottom-most edge lines vertically, but you have this offset as 0.6 mm.

Please add a vertical PCB edge line on the left side extending as far up as the one on the right side.

The drawing shows the shield pads near the top of the footprint only as rectangular pads on the bottom, not as plated-through holes. Also, though it is quite imprecise about their dimensions, it does show the spacing between their outer edges as 7.65 mm, but you have this as 7.875 mm. Presumably this dimension should be centered in the X dimension on the 8.2 mm-wide section of PCB. Further, their bottom is shown as 3.45 mm from the bottom PCB edge line, so please fix this as well.

Please move the "PCB Edge" text to be centered on the bottom edge lines, so it's clearer what line is being labeled.

As described in KLC rule F5.3, courtyard clearance for should be 0.5 mm from PCB edge lines and exposed copper all around. This should be rounded up, if necessary, to keep the endpoints of the lines on a 0.01 mm grid.

@Ratfink Ratfink self-assigned this May 7, 2018
@poeschlr poeschlr added Pending changes Addition Adds new footprint to library labels Jan 1, 2019
@Misca1234
Copy link
Collaborator

Misca1234 commented Feb 2, 2019

@Ratfink
I think this one is abandoned, do you want to take over it, if not, I can do it.

@Ratfink
Copy link
Collaborator

Ratfink commented Feb 2, 2019

There's exactly zero chance I'll be able to work on this in the next two weeks. If you want to take it over, be my guest. 🙂

@Misca1234
Copy link
Collaborator

Ok, I am on it

@Misca1234
Copy link
Collaborator

This have been repushed
#1365

@Misca1234 Misca1234 closed this Feb 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library Pending changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants