Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

USB_A_CUI_UJ2-ADH-TH_Horizontal_stacked USB A receptical #2147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

USB_A_CUI_UJ2-ADH-TH_Horizontal_stacked USB A receptical #2147

wants to merge 1 commit into from

Conversation

chmorgan
Copy link
Collaborator

@chmorgan chmorgan commented Mar 16, 2020

Fab dimensions from datasheet

Adjusted silk to avoid going through NPTH

Courtyard 0.5mm from fab per connector requirements

Centered on pin 1, which was made square

Beveled fab corner to indicate corner with pin 1 after installation and for reference.

Added pin 1 indicator to silk outside of part outline

Added datasheet

image

https://www.cuidevices.com/product/resource/uj2-adh-th.pdf

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

Fab dimensions from datasheet

Adjusted silk to avoid going through NPTH

Courtyard 0.5mm from fab per connector requirements

Centered on pin 1, which was made square

Beveled fab corner to indicate corner with pin 1 after installation and for reference.

Added pin 1 indicator to silk outside of part outline

Added datasheet
@myfreescalewebpage myfreescalewebpage added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Mar 20, 2020
@chmorgan chmorgan closed this Jul 3, 2020
@chmorgan chmorgan reopened this Jul 3, 2020
@chmorgan
Copy link
Collaborator Author

@cpresser would you be able to review this one? I can't review my own PRs, for good reason of course, and this one has been pending for some time.

@cpresser
Copy link
Contributor

Yes, can do.
Currently I am not really active here. Lots of stress with my job. And the hackerspace is closed due to covid.
But this is a good opportunity to get back into the kicad game.

@cpresser cpresser self-assigned this Jul 15, 2020
@cpresser cpresser removed the Pending reviewer A pull request waiting for a reviewer label Jul 15, 2020
@cpresser
Copy link
Contributor

Alright,
Style-wise I did compare this one to USB_A_Wuerth_61400826021_Horizontal_Stacked which is a similar device. The library does have some different

  • Pin1 style on F.Fab: I would prefer a chevron below the chevron on F.SilkS. The chamfered corner is really far away from Pin1.
  • Rotation is different from the other USB-A connectors in the library. But this connector has Pin1 not on the outer row. I am not sure on how to handle this best. Any thoughts?
  • Position and Drill-Size of Pins are correct
  • The Silk-Screen of the 'Springs' is not exactly 6.0mm apart. But that is a minor issue.
  • The F.Fab body dimensions don't seem to match at all. I got 16.92mm in X- and 17.14mm in Y-Direction. That does not match anything I found in the datasheet.
  • F.Fab again, it would be good to see the 'flaps' on the entry of the plug, similar to the würth footprint.
  • Name: Stacked should start with an uppercase S
  • The Datasheet has the PCB-Edge line. We did include that in several other footprints (for example USB_Micro-B_Amphenol_10103594-0001LF_Horizontal), why not add it here as well?

@cpresser
Copy link
Contributor

@chmorgan ping. Do you want to continue with this one?

@chmorgan
Copy link
Collaborator Author

Hi @cpresser. I would like to update it and have it considered for inclusion. Is it ok if I update it this weekend and push an update then?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library Pending changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants