Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add footprints for Cyntec DC/DC modules MUN12AD0x-SH #2100

Merged
merged 2 commits into from
Feb 23, 2020

Conversation

rleh
Copy link
Contributor

@rleh rleh commented Feb 20, 2020

@rleh rleh changed the title Add Cyntec_QFN-8-3EP_3.5x3.5x1.7mm_P0.8mm Add QFN-8-3EP footprint for Cyntec DC/DC power module Feb 20, 2020
@rleh rleh changed the title Add QFN-8-3EP footprint for Cyntec DC/DC power module Add QFN-8-1EP and QFN-8-3EP footprints for Cyntec DC/DC power modules Feb 20, 2020
@poeschlr
Copy link
Collaborator

poeschlr commented Feb 22, 2020

The generic library dfn/qfn library is only allowed to hold generic footprints created with the ipc generators found here https://github.com/pointhi/kicad-footprint-generator/tree/master/scripts/Packages/Package_NoLead__DFN_QFN_LGA_SON (suggested footprint is to be ignored)

Specialized footprints should go into more specialized libraries.

And as this really does not look like a DFN package but more like a pcb that happens to emulate a similar land pattern to a no lead package. Which means i would place it into the DC/DC converter lib.

Edit: which means i am not even sure i would mention DFN in the footprint name. it definetly is not a QFN!

@poeschlr poeschlr added the Addition Adds new footprint to library label Feb 22, 2020
@poeschlr poeschlr self-assigned this Feb 22, 2020
@poeschlr
Copy link
Collaborator

The fab outline must represent the nominal body size, the courtyard clearance must be 0.25mm all around.
Screenshot from 2020-02-22 18-01-14

Screenshot from 2020-02-22 18-11-33

@rleh
Copy link
Contributor Author

rleh commented Feb 22, 2020

Thanks for reviewing!

I would move the footprints to Converter_DCDC.pretty/Converter_DCDC_Cyntec_MUN12AD0{1,3}-SH.kicad_mod, ok?

@rleh
Copy link
Contributor Author

rleh commented Feb 22, 2020

Here are drawings of the fixed Fab-layer outline and courtyard clearances:

Converter_DCDC_Cyntec_MUN12AD01-SH.kicad_mod

Converter_DCDC_Cyntec_MUN12AD03-SH.kicad_mod

@rleh
Copy link
Contributor Author

rleh commented Feb 22, 2020

The 3D model reference for both footprints is ${KISYS3DMOD}/Converter_DCDC.3dshapes/Converter_DCDC_Cyntec_MUN12AD0x-SH.wrl, because the 3D models are identical.

@rleh rleh changed the title Add QFN-8-1EP and QFN-8-3EP footprints for Cyntec DC/DC power modules Add footprints for Cyntec DC/DC modules MUN12AD0x-SH Feb 22, 2020
@rleh rleh requested a review from poeschlr February 22, 2020 20:31
@poeschlr poeschlr closed this Feb 23, 2020
@poeschlr poeschlr reopened this Feb 23, 2020
@poeschlr poeschlr added Ready for review Use this to mark pull requests that are updated but you could not review instantly and removed Pending changes labels Feb 23, 2020
@poeschlr
Copy link
Collaborator

I would suggest moving silk a bit closer to the part outline such that it is more useful for aligning the part.

@rleh
Copy link
Contributor Author

rleh commented Feb 23, 2020

Ok.
grafik
grafik

@poeschlr
Copy link
Collaborator

thanks

@poeschlr poeschlr merged commit 8edb799 into KiCad:master Feb 23, 2020
@poeschlr poeschlr removed the Ready for review Use this to mark pull requests that are updated but you could not review instantly label Feb 23, 2020
@poeschlr poeschlr removed their request for review February 23, 2020 20:28
@rleh rleh deleted the cyntec_qfn-8-3 branch February 23, 2020 20:35
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.6 milestone Feb 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants