Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add Lumex SML-LX0303SIUPGUSB #1990

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

jordiorlando
Copy link
Contributor

@jordiorlando jordiorlando commented Dec 5, 2019

Add Lumex SML-LX0303SIUPGUSB (little sibling to #1698)

Datasheet

LED_Lumex_SML-LX0303SIUPGUSB

LED_Lumex_SML-LX0303SIUPGUSB


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

@jordiorlando jordiorlando mentioned this pull request Dec 5, 2019
5 tasks
@antoniovazquezblanco antoniovazquezblanco added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Dec 6, 2019
@poeschlr poeschlr self-assigned this Mar 6, 2020
@poeschlr poeschlr removed the Pending reviewer A pull request waiting for a reviewer label Mar 6, 2020
@poeschlr
Copy link
Collaborator

poeschlr commented Mar 6, 2020

Thanks looks good. For reference the dimensioned drawing of your footprint
Screenshot from 2020-03-06 18-10-26

@poeschlr poeschlr merged commit 0fed9b0 into KiCad:master Mar 6, 2020
@jordiorlando
Copy link
Contributor Author

@poeschlr woo, thanks! Hopefully #1698 gets merged soon too since it's almost identical 😄

@jordiorlando jordiorlando deleted the Lumex_SML-LX0303SIUPGUSB branch March 8, 2020 05:04
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.6 milestone Mar 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants