Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add USB Micro-B Amphenol 10103592-0001LF Connector #1960

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dokthar
Copy link

@dokthar dokthar commented Nov 11, 2019

Add footprint for the USB Micro-B connector Amphenol 10103592-0001LF

  • Provide a URL to a datasheet for the footprint(s) you are contributing
    datasheet
  • An example screenshot image is very helpful
    usb_Amph
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
    No matching 3D model exists.
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.
    Breaks rule KLC F4.2 "Pin 1 should be located at the top left"
    This connector is a reverse mount, all the pins are ordered in the opposite direction from "normal" USB Micro-B connector. I think it make sense to keep pin 1 in the top right corner (As done in footprint USB_Micro-AB_Molex_47590-0001).

@CLAassistant
Copy link

CLAassistant commented Nov 11, 2019

CLA assistant check
All committers have signed the CLA.

@antoniovazquezblanco antoniovazquezblanco added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Nov 11, 2019
@jneiva08
Copy link
Contributor

Hi,

You forgot to add the default 3D (KLC F9.3)

@dokthar dokthar force-pushed the usb-Amphenol_10103592 branch from 6d4294d to 408d077 Compare November 12, 2019 10:05
@dokthar
Copy link
Author

dokthar commented Nov 12, 2019

latest changes:

  • Removed F.Paste Layer in through hole pad
  • Added default 3D model (F9.3)

@poeschlr
Copy link
Collaborator

poeschlr commented Mar 6, 2020

Please rotate the footprint such that pad 1 is closest to the top left corner.
Is there a reason that part of the PCB edge is on the drawings layer instead of edge cuts?

Two dimensions are off
Screenshot from 2020-03-06 22-31-55

The body dimensions and courtyard clearances are also wrong
Screenshot from 2020-03-06 22-39-20

@poeschlr poeschlr self-assigned this Mar 6, 2020
@poeschlr poeschlr added Pending changes and removed Pending reviewer A pull request waiting for a reviewer labels Mar 6, 2020
@dokthar dokthar force-pushed the usb-Amphenol_10103592 branch from 408d077 to a8ff8bf Compare April 5, 2020 19:03
@dokthar
Copy link
Author

dokthar commented Apr 5, 2020

I've fixed the two dimensions that were off, and rotated the footprint such that pad 1 is in top left corner.
I have no idea of what the rules are for body dimension and courtyard, here is what I've done:
For the body dimension I have tried to follow the maximum body dimension shown in the datasheet,
for the courtyard I've put 0.5mm from the closest pad or body boundary.

Also I've placed the footprint anchor in the center of the body boundary.

@poeschlr
Copy link
Collaborator

The KLC specifies the use of nominal so please use it not maximum.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library Pending changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants