Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

add Alps SKRTLAE010 horizontal push button #1889

Merged
merged 4 commits into from
Jan 3, 2020
Merged

Conversation

hvraven
Copy link
Contributor

@hvraven hvraven commented Oct 4, 2019

This adds a horizontal SMT push button from Alps SKRTAE010. If this footprint is fine I would create the SKRTB variant as well which lacks the guidance holes. Designed to be used with the standard SW_Push symbol (however a SW_Push_MP might be nice to have).

I placed the center of the symbol in between the guidance holes, thats how I read the guidance lines in the drawing. I also used roundrects instead of square rectangles, I hope thats ok.

Screenshot_20191004_101655


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@poeschlr poeschlr added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Oct 5, 2019
@poeschlr
Copy link
Collaborator

poeschlr commented Oct 5, 2019

please inlcude -MP in the name (after 1P1T) I did not review this any further

@cpresser
Copy link
Contributor

cpresser commented Oct 5, 2019

  • The center location is okay, its in the middle of the guide bosses.
  • please add the keepout area as shown here:
    image
  • Body size is off by 0.01mm
  • Then Pin1 marker seems wrong. There are two Pin 1, why did you choose the left one? This also raises the question if we need a Pin1 marker at all. If yes, it should also be on F.Fab. @poeschlr Any thoughts on this?

@poeschlr poeschlr added Pending changes and removed Pending reviewer A pull request waiting for a reviewer labels Oct 13, 2019
@hvraven
Copy link
Contributor Author

hvraven commented Dec 25, 2019

Fixed the body size and added the keepout as shown below. Also dropped the pin 1 indicator. I added it in the beginning due to the labeling of the original datasheet. Then I did not delete it at the point where I realised that the pads on the side are connected to each other.

Screenshot_20191225_105858

@cpresser cpresser merged commit d14e240 into KiCad:master Jan 3, 2020
@cpresser
Copy link
Contributor

cpresser commented Jan 3, 2020

Thanks!

@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.6 milestone Jan 4, 2020
@hvraven hvraven deleted the skrt branch April 15, 2020 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants