Skip to content
This repository was archived by the owner on Oct 2, 2020. It is now read-only.

Conversation

chschlue
Copy link
Contributor

#1804


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@chschlue chschlue added the Bug Fix footprint existing in the library label Sep 11, 2019
@chschlue chschlue requested a review from evanshultz September 11, 2019 20:59
@evanshultz
Copy link
Collaborator

Pad size fix looks good.

@evanshultz
Copy link
Collaborator

@chschlue
Can you please confirm that the fab drawing needs to be updated? I think so, but would like your confirmation. I would like to fix the existing footprints before reviewing new ones.

@chschlue
Copy link
Contributor Author

@evanshultz
All currently open DirectFET PRs still need an update. I can start with the existing FPs if you prefer.

@chschlue
Copy link
Contributor Author

@evanshultz ping

@poeschlr
Copy link
Collaborator

@chschlue no need to ping after just 12 hours. Github allows us maintainers to see if an assigned pull request had activity since we last visited. (In your pull requests go to "assigned" and there you will see pull requests with unseen activity marked with a blue bar (You can also sort by recent activity). Pinging the maintainer really only is necessary if a lot of time has passed without activity on their side.

@chschlue
Copy link
Contributor Author

chschlue commented Sep 13, 2019

@poeschlr
This is the way @evanshultz and me have been doing the 40 or so DirectFET PRs all week long.
What exactly is suddenly wrong with it?

@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.5 milestone Sep 13, 2019
@poeschlr
Copy link
Collaborator

The same as at the beginning of the week. I can not really say if evan is as effected by something like this as i have been when somebody did this to me. But i can for sure tell you that it is annoying that the full dashboard is full of repeated "ping" comments (which means it is much more likely that i miss stuff that would be important to see)

@evanshultz evanshultz merged commit 5f082c5 into KiCad:master Sep 13, 2019
@evanshultz
Copy link
Collaborator

@chschlue
I wanted to get these footprints done and I had them all opened in tabs so I kept charging ahead. But I agree with Rene, that no ping is necessary because I will see all PRs. I just wanted to get these done first.

Thanks for updating all of them!

@chschlue
Copy link
Contributor Author

@evanshultz
Ok, so the pings didn't hurt much either? If they did, I apologize.

@evanshultz
Copy link
Collaborator

No worries. They're just unnecessary as Rene said above.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix footprint existing in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants