Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Fischer FK224 ... 220 1 heatsink #1722

Merged
merged 5 commits into from
Jan 5, 2020
Merged

Conversation

evanshultz
Copy link
Collaborator

https://www.fischerelektronik.de/web_fischer/en_GB/$catalogue/fischerData/PR/FK224_220_1_/datasheet.xhtml?branch=heatsinks

I used silk lines to help indicate where the TO220 device should be placed. Pads are placed at the center of the legs. There is a keepout noted to help catch approximately where the legs touch the PCB surface and could scratch the mask to create a short.
image

image


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@antoniovazquezblanco antoniovazquezblanco added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Jul 19, 2019
@poeschlr poeschlr self-assigned this Oct 28, 2019
@poeschlr
Copy link
Collaborator

Might it be a good idea to somehow separate 224 and 220 in the name? for example by a dash or underline character?

The drill size might be a bit small. The diagonal of the nominal "lead" dimension is already 1.77mm. So even a bit of tolerance would mean that the part would no longer fit into a 1.8mm hole. To be honest i would probably go with 2mm.

The silk outline should be moved outside (the outermost outline).

@poeschlr poeschlr added Pending changes and removed Pending reviewer A pull request waiting for a reviewer labels Oct 28, 2019
- Update footprint name
- Enlarge drill holes to 2mm
- Push silk outside fab lines
@evanshultz
Copy link
Collaborator Author

Thanks for looking.

I think the full PN includes a two-character surface finish so I used xx as a wildcard. Would you like this footprint specific to a finish for 3D model uniqueness? There also appears to be a space before the trailing number which I have omitted.

Good catch. Holes are now 2mm.

I have never understood this rule. You did clarify it a bit that only 'extra' silk can be under THT parts but I really don't understand why.

image

@poeschlr
Copy link
Collaborator

poeschlr commented Nov 9, 2019

The outermost silk outline should be visible after assembly this is why it must be outside. This is because the outermost lines are in part used for quality control. (Checking if the assembly was successful and everything is aligned. This would be impossible if the silk line is covered by the body.)

Normally no silk is allowed under parts as it negatively impacts solderability. But THT parts are not affected by this and silk under it can be used to help identify the orientation for manual assembly which is why we allow it.

@evanshultz
Copy link
Collaborator Author

Is this ready to be merged or is there still work to be done?

@poeschlr poeschlr added Ready for review Use this to mark pull requests that are updated but you could not review instantly and removed Pending changes labels Nov 12, 2019
@poeschlr
Copy link
Collaborator

poeschlr commented Jan 5, 2020

looks good now, thanks

@poeschlr poeschlr merged commit e47dbea into KiCad:master Jan 5, 2020
@poeschlr poeschlr removed the Ready for review Use this to mark pull requests that are updated but you could not review instantly label Jan 5, 2020
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.6 milestone Jan 5, 2020
@evanshultz evanshultz deleted the fischer-fk224 branch January 6, 2020 17:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants