Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

MountingEquipment: moving DIN Rail adapter #1252

Merged
merged 1 commit into from
Jan 2, 2019

Conversation

myfreescalewebpage
Copy link
Collaborator

Only moving the DIN Rail footprint and 3D following discussion at #1245. No other modification of the part.


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

@myfreescalewebpage myfreescalewebpage added Enhancement Improves existing footprint in the library Pending reviewer A pull request waiting for a reviewer labels Jan 2, 2019
@poeschlr
Copy link
Collaborator

poeschlr commented Jan 2, 2019

I seem to remember that this one is connected to a symbol. Does this need fixing as well?

@poeschlr poeschlr self-assigned this Jan 2, 2019
@poeschlr poeschlr removed the Pending reviewer A pull request waiting for a reviewer label Jan 2, 2019
@ferdymercury
Copy link
Contributor

ferdymercury commented Jan 2, 2019

Yep, here it was done with MountingHole: KiCad/kicad-symbols#1095
But the default footprint was removed, so that no change is needed.

@myfreescalewebpage
Copy link
Collaborator Author

myfreescalewebpage commented Jan 2, 2019

@poeschlr you are right, but the symbol has no default footprint :)

@poeschlr
Copy link
Collaborator

poeschlr commented Jan 2, 2019

In this case it is ok. I however feel the symbol has a way too specific footprint filter. I would not really suggest to list the screw size. Might be something that should be fixed.

@poeschlr poeschlr merged commit bf0a1d2 into KiCad:master Jan 2, 2019
@myfreescalewebpage
Copy link
Collaborator Author

@poeschlr probably yes, will see in the future depending of the footprints proposed by the community. Actually the available footprint is M3 only.

@myfreescalewebpage myfreescalewebpage deleted the MountingEquipment branch January 3, 2019 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing footprint in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants