Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add Bourns TC33X SMD potentiometer #1169

Merged
merged 3 commits into from
Dec 16, 2018

Conversation

MatthewStephenson
Copy link
Contributor

@MatthewStephenson MatthewStephenson commented Dec 14, 2018

Bourns TC33X SMD Potentiometer

Datasheet: https://www.bourns.com/pdfs/TC33.pdf

image

The automated check is failing on the "centre of footprint" check by 0.1mm, because I've placed the anchor at the centre of the rotating part, as per the datasheet diagram, and the pads are not symmetrical in size or placement.

As always, comments and suggestions welcomed.

@poeschlr poeschlr self-assigned this Dec 15, 2018
@poeschlr poeschlr added the Addition Adds new footprint to library label Dec 15, 2018
@poeschlr
Copy link
Collaborator

Could you add the suffix _Vertical to the footprint name?

We might want to indicate the circular area required for the "wiper" (3.6mm diameter). Maybe add a circle to the comments layer. Optionally also some note on the comments layer telling the user that the wiper can be anywhere inside this circle. (The courtyard area is already bigger than this but it might still be valuable information to the user.)

For reference the dimensioned drawing:
screenshot from 2018-12-15 18-34-29

This is an alternative part to the obsolete one that would have been added in #1143

@MatthewStephenson
Copy link
Contributor Author

Thanks for the review, I've made the requested changes. I kept the text about the wiper small so it fits inside the footprint which means you have to zoom in quite far to read it. Hope that was the right choice.

image

Out of interest, what tool did you use to make the dimensioned drawing?

@poeschlr
Copy link
Collaborator

I would suggest to move the circle to the Dwgs.User layer.

I have a tutorial for creating these drawings: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279

@MatthewStephenson
Copy link
Contributor Author

Ok, moved it to the Dwgs.User layer. You did say "add a circle to the comments layer"!

@poeschlr
Copy link
Collaborator

Yup sorry about the confusion. Thanks for the quick fix and your contribution in general.

@poeschlr poeschlr merged commit ae1824c into KiCad:master Dec 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants