Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

added FP for 9V battery holder 12BH611-GR #1028

Merged
merged 1 commit into from
Oct 19, 2018

Conversation

cyber-murmel
Copy link
Contributor

@cyber-murmel cyber-murmel commented Oct 18, 2018

This is the footprint for a fairly inexpensive 9V battery holder.


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
    • fp editor screenshot
    • 3D render screenshot
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
    • there are none
  • Check the output of the Travis automated check scripts - fix any errors as required

@cyber-murmel cyber-murmel force-pushed the 12BH611-GR branch 3 times, most recently from ad401d0 to ed79dd8 Compare October 18, 2018 08:05
@Misca1234
Copy link
Collaborator

Hi

How did you reach the x distance of -24.15 for the lower NPTH mounting hole?
Should it not be 24.9 (14 + 10.9) ?

The 3D name is different from the foot print name, any reason for that ?
BatteryHolder_Eagle_12BH611-GR
BatteryHolder_Bulgin_Eagle_12BH611-GR

@cyber-murmel
Copy link
Contributor Author

I fixed both.
The 3D name was a copy paste mistake.
I thought the lower mounting hole was on X axis in the middle of the of the case, not in the middle of the other mounting holes. Changed it to -24.9 now.

@Misca1234
Copy link
Collaborator

great, thx

@Misca1234 Misca1234 merged commit fc49117 into KiCad:master Oct 19, 2018
@cyber-murmel cyber-murmel deleted the 12BH611-GR branch October 19, 2018 16:33
@myfreescalewebpage myfreescalewebpage added the Addition Adds new footprint to library label Mar 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants