Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Common mode choke location #1645

Open
evanshultz opened this issue Jun 13, 2019 · 3 comments
Open

Common mode choke location #1645

evanshultz opened this issue Jun 13, 2019 · 3 comments
Labels
Bug Fix footprint existing in the library Enhancement Improves existing footprint in the library
Milestone

Comments

@evanshultz
Copy link
Collaborator

We have CMC footprints named in various and inconsistent ways, and I'm not sure that they belong in an inductor library since their purpose is rather different than just an inductor:

  • Inductor_SMD: L_CommonMode_Wuerth_WE-SL2 (qty=1)
  • Inductor_THT: Choke_EPCOS_B82722A (qty=1)
  • Inductor_THT: Choke_Schaffner_RN* (qty=16)
  • Inductor_THT: L_CommonMode_Toroid_Vertical* (qty=10, and actually Bourns 81xx-RC)
  • Inductor_THT: L_CommonMode_Wuerth_WE-CMB* (qty=6)

I'm thinking they should be grouped together. Perhaps they all start with L_CommonModeChoke or just L_CommonMode?

And it seems like there's enough to populate a new footprint library. Perhaps CommonModeChoke or L_CommonMode (I suppose we could be split by SMD and THT if desired)?

Anybody else have feelings on this?

@cpresser
Copy link
Contributor

I agree, they deserve a different library.
I think "L_CommonModeChoke" is a good name, I would not shorten it to "L_CommonMode".

Will this be a v6 thing? Since moving footprints will break existing designs?

@antoniovazquezblanco antoniovazquezblanco added Bug Fix footprint existing in the library Enhancement Improves existing footprint in the library labels Aug 26, 2019
@evanshultz
Copy link
Collaborator Author

Moving footprints should be OK since footprints are embedded into the board file. Rene has been allowing footprint changes at any time.

v6 should do a similar thing for symbols so we may get the same flexibility there too.

But regardless, we should use common sense and not move things around all the time for little benefit. IMO, even if it doesn't break designs, this isn't worth doing now and can wait for v6 or shortly before.

@poeschlr
Copy link
Collaborator

poeschlr commented Sep 10, 2019

I advise against making new libs even for the footprint side as users lib tables do not update. (At least not new libs for old footprints. Meaning do not split libs during a minor release)

Edit: plus while footprints are embedded, 3d models are not.

@cpresser cpresser added this to the 6.0.0 milestone Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix footprint existing in the library Enhancement Improves existing footprint in the library
Projects
None yet
Development

No branches or pull requests

4 participants