Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint fixes #197

Merged
merged 5 commits into from
Apr 12, 2019
Merged

Eslint fixes #197

merged 5 commits into from
Apr 12, 2019

Conversation

emackey
Copy link
Member

@emackey emackey commented Apr 12, 2019

Fixes #158, there should be no more eslint messages after this.

  • new operator is specifically allowed to construct classes beginning with lowercase gl
  • Windows platforms use LF for (js, json, html, css) files now, to enforce line endings (old repos on Windows before this change will need to delete and reset, or re-clone these files, to get clean LF copies).
  • VSCode extension recommendations added: ESLint, a shader syntax highlighter, and glTF Tools
  • List of eslint included & excluded files tweaked

@donmccurdy
Copy link

I think we should rename the gl classes at some point... they read very awkwardly to me, and I don't think matching the glTF capitalization in code is worthwhile.

@emackey
Copy link
Member Author

emackey commented Apr 12, 2019

Out of scope for this PR, but yes I agree.

@emackey emackey merged commit 24ccc42 into reference-viewer Apr 12, 2019
@emackey emackey deleted the eslint-fixes branch April 12, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants