Windows EOL fix #125
Merged
Windows EOL fix #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is just a |
emackey
pushed a commit
that referenced
this pull request
Mar 3, 2021
added transmission pass to punctual lighting transmission (GSVN-280)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git had mistaken some of the smaller HDR files for text-based files, not binary. This change to
.gitattributesspecifically marks all such image files as binary files, to protect them from end-of-line processing.On Windows,
\nin certain small HDR files (such aspapermill/specular/specular_right_8.hdr) were being automatically converted to\r\n, which caused an infinite loop to appear here:https://github.com/KhronosGroup/glTF-WebGL-PBR/blob/3186d988507d2bf94ff2940c2e2cf1b597a5d691/libs/hdrpng.js#L156
The corrupted files never matched the regex, and the entire browser hung.
NOTE for Windows users: After pulling this change, you may need to manually delete your
assets/imagesfolder, as it will still contain the old corrupted files. Then use git commands to recreate the folder locally. (I didn't have other pending changes, so I took the heavy-handed approach ofgit reset --hardon my copy. Make sure you have anything important checked in first.)