Specialize EXT_texture_norm16 to WebGL 2.0. #3136
Conversation
|
Note that earlier change #3116 also promoted this to community approved but let's hold off on that until we have agreement on all of the details of this extension spec. |
Revise conformance2/extensions/ext-texture-norm16.html to mandate that 16-bit signed normalized textures are not color renderable. That functionality is covered under EXT_render_snorm, not currently exposed to WebGL. Partially addresses KhronosGroup#3114.
kenrussell
force-pushed
the
ext-texture-norm16-is-webgl-2-specific
branch
from
977cef2 to
96b072b
Compare
|
Revised to remove the EXT_render_snorm dependence, and added negative tests forbidding the SNORM16 texture formats from being advertised as color-renderable. |
|
|
||
| testSnorm16Unrenderable(ext.R16_SNORM_EXT, gl.RED, gl.SHORT); | ||
| testSnorm16Unrenderable(ext.RG16_SNORM_EXT, gl.RG, gl.SHORT); | ||
| testSnorm16Unrenderable(ext.RGB16_SNORM_EXT, gl.RGB, gl.SHORT); |
There was a problem hiding this comment.
https://www.khronos.org/registry/OpenGL/extensions/EXT/EXT_render_snorm.txt doesn't include RGB16_SNORM
But since it's negtive test, I think it be okay as long as this wouldn't lead to crash.
There was a problem hiding this comment.
If it crashes, that would make this an essential negative test! :)
There was a problem hiding this comment.
Thanks for pointing that out. It's probably an oversight in EXT_render_snorm; there is a reference to RGB16_SNORM_EXT in the section "Interactions with EXT_texture_norm16".
|
|
||
| var wtu = WebGLTestUtils; | ||
| var gl = wtu.create3DContext(); | ||
| var gl = wtu.create3DContext(null, null, 2); |
There was a problem hiding this comment.
Don't need this, since this is in conformance2/*.
There was a problem hiding this comment.
It's needed to support navigating directly to this test rather than running it inside the harness, which makes debugging simpler. Most of the other tests under conformance2/ do this; it was an oversight that this test didn't.
|
Thanks @shrekshao @jdashg for your reviews. Merging now. |
3 participants
Revise conformance2/extensions/ext-texture-norm16.html to mandate that
16-bit signed normalized textures are not color renderable. That
functionality is covered under EXT_render_snorm, not currently exposed
to WebGL.
Partially addresses #3114.