Test WebGL 2's new vertex attribute types #3135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
INT, UNSIGNED_INT, HALF_FLOAT, INT_2_10_10_10_REV, and UNSIGNED_INT_2_10_10_10_REV
kdashg
approved these changes
Aug 6, 2020
Contributor
kdashg
left a comment
kdashg
left a comment
There was a problem hiding this comment.
Huh, I figured we picked up FIXED in WebGL 2, but if there's no consensus we can remove it.
Contributor
Author
|
I have no opinion on whether it should be supported. I don't know why it was excluded to begin with. |
Member
|
Thanks for revising these tests @jdarpinian . Regarding WebGL's removal of FIXED type vertex attributes - I recall that they were only supported on OpenGL ES when WebGL 1.0 was under active development, so to eliminate costly emulation on desktop they were removed from the spec. Since there's been essentially zero demand for them since, I agree with asserting that they're disallowed in WebGL 2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INT, UNSIGNED_INT, HALF_FLOAT, INT_2_10_10_10_REV, and UNSIGNED_INT_2_10_10_10_REV.
Also test that FIXED is not supported in WebGL 2, as the restriction from WebGL 1 was not lifted. Firefox seems to currently support FIXED in WebGL 2.