Skip to content

Expect gl.INVALID_VALUE for gl.shaderSource for invalid shader in character-set.html #3128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shrekshao merged 1 commit into from
Jul 28, 2020
Merged

Expect gl.INVALID_VALUE for gl.shaderSource for invalid shader in character-set.html #3128

shrekshao merged 1 commit into from
Jul 28, 2020

Conversation

@shrekshao
Copy link
Member

@shrekshao shrekshao commented Jul 27, 2020

Following up #3124

We now expect gl.INVALID_VALUE for gl.shaderSource instead of use GLSLConformanceTester for the overall test.

@shrekshao shrekshao requested a review from kdashg July 27, 2020 20:41
@shrekshao
Copy link
Member Author

shrekshao commented Jul 28, 2020

As this is addressing comments from #3124
I'm going to merge this for further webgl roll and chrome patch impl

@shrekshao shrekshao merged commit c1d5cef into KhronosGroup:master Jul 28, 2020
@kenrussell
Copy link
Member

kenrussell commented Jul 28, 2020

LGTM after the fact.

@kenrussell kenrussell mentioned this pull request Jan 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kdashg kdashg Awaiting requested review from kdashg

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shrekshao @kenrussell