Skip to content

Re-enable requestVideoFrameCallback for image_bitmap_from_video tests. #3096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shrekshao merged 1 commit into from
Jun 5, 2020
Merged

Re-enable requestVideoFrameCallback for image_bitmap_from_video tests. #3096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions sdk/tests/js/tests/tex-image-and-sub-image-2d-with-image-bitmap-from-video.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@ function generateTest(internalFormat, pixelFormat, pixelType, prologue, resource

var videoNdx = 0;
var video;

// crbug.com/1090960: createImageBitmap is failing for some
// videos even after requestVideoFrameCallback fires.
wtu.disableRequestVideoFrameCallback();
function runNextVideo() {
if (video) {
video.pause();
Expand Down
13 changes: 0 additions & 13 deletions sdk/tests/js/webgl-test-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2913,26 +2913,14 @@ var requestAnimFrame = function(callback) {
_requestAnimFrame.call(window, callback);
};

var _disableRequestVideoFrameCallback = false;

/**
* Provides video.requestVideoFrameCallback in a cross browser way.
* Returns a property, or undefined if unsuported.
*/
var getRequestVidFrameCallback = function() {
if (_disableRequestVideoFrameCallback)
return undefined;
return HTMLVideoElement.prototype["requestVideoFrameCallback"];
};

/**
* Disables the use of requestVideoFrameCallback in order to work
* around bugs in implementations.
*/
var disableRequestVideoFrameCallback = function() {
_disableRequestVideoFrameCallback = true;
};

var _cancelAnimFrame;

/**
Expand Down Expand Up @@ -3416,7 +3404,6 @@ var API = {
comparePixels: comparePixels,
destroyAllContexts: destroyAllContexts,
destroyContext: destroyContext,
disableRequestVideoFrameCallback: disableRequestVideoFrameCallback,
dispatchPromise: dispatchPromise,
displayImageDiff: displayImageDiff,
drawUnitQuad: drawUnitQuad,
Expand Down