Skip to content

Add tests to verify toDataURL images are the correct orientation for premultiplyAlpha=false #3089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kdashg merged 3 commits into from
Jun 2, 2020
Merged

Add tests to verify toDataURL images are the correct orientation for premultiplyAlpha=false #3089

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9ee5af
Add tests to verify toDataURL images are the correct orientation
nkronlage May 31, 2020
8591114
Remove trailing whitespace
nkronlage May 31, 2020
e4e2498
PR feedback
nkronlage Jun 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 44 additions & 11 deletions sdk/tests/conformance/canvas/to-data-url-test.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,24 +26,53 @@
var main = function() {
description();
ctx = document.getElementById("c2d").getContext("2d");
gl = wtu.create3DContext("c3d");

if (!gl) {
testFailed("can't create 3d context");
finishTest();
return;
}
var updateCanvas = function(width, height, attributes) {
var canvas = document.getElementById("c3d");

if (gl && (gl.attributes !== attributes)) {
// Attributes changed, recreate the canvas
var newCanvas = canvas.cloneNode();
canvas.parentNode.replaceChild(newCanvas, canvas);
canvas = newCanvas;
gl = undefined;
}

canvas.width = width;
canvas.height = height;

if (!gl) {
gl = wtu.create3DContext(canvas, attributes);

if (!gl) {
testFailed("can't create 3d context");
return;
}

gl.attributes = attributes;
}

return gl;
};

var clearRect = function(gl, x, y, width, height, color) {
gl.clearColor(color[0] / 255, color[1] / 255, color[2] / 255, color[3] / 255);
gl.scissor(x, y, width, height);
gl.clear(gl.COLOR_BUFFER_BIT);
};

var testSize = function(gl, width, height, callback) {
debug("testing " + width + " by " + height);
gl.canvas.width = width;
gl.canvas.height = height;
var testSize = function(width, height, attributes, callback) {
let attributesDebugMessage = "";
if (attributes) {
attributesDebugMessage = " attributes: " + JSON.stringify(attributes);
}
debug("testing " + width + " by " + height + attributesDebugMessage);
var gl = updateCanvas(width, height, attributes);
if (!gl) {
callback();
return;
}

gl.viewport(0, 0, width, height);
gl.enable(gl.SCISSOR_TEST);

Expand Down Expand Up @@ -71,6 +100,9 @@
});
};

const premultipliedAlphaAttributes = {
premultipliedAlpha: false,
};
var tests = [
{ width: 16 , height: 16 , },
{ width: 16 - 1, height: 16 , },
Expand All @@ -87,6 +119,7 @@
{ width: 512 - 1, height: 512 - 1, },
{ width: 512 + 1, height: 512 - 1, },
{ width: 512 - 1, height: 512 + 1, },
{ width: 16 , height: 16 , attributes: premultipliedAlphaAttributes},
];
var testIndex = 0;
var runNextTest = function() {
Expand All @@ -95,7 +128,7 @@
return;
}
var test = tests[testIndex++];
testSize(gl, test.width, test.height, function() {
testSize(test.width, test.height, test.attributes, function() {
setTimeout(runNextTest, 0);
})
};
Expand Down