Fix crossorigin tests to default to remote-web-url, but fallback to l… #3052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocal on localhost.
kenrussell
requested changes
Apr 10, 2020
sdk/tests/conformance/textures/misc/origin-clean-conformance-offscreencanvas.html
Show resolved
Hide resolved
kenrussell
approved these changes
Apr 10, 2020
sdk/tests/conformance/textures/misc/origin-clean-conformance-offscreencanvas.html
Show resolved
Hide resolved
This was referenced May 18, 2020
kenrussell
added a commit
to kenrussell/WebGL
that referenced
this pull request
Jun 5, 2020
The earliest version of this code, which was robust, made the determination of whether to use a local or remote URL cor cross-origin images up front. Network timeouts from machines that deliberately aren't connected to the open Internet can't be relied upon as a fallback mechanism. Change the code back to examine the test's URL and choose whether to load local or remote images based on that. Follow-on to KhronosGroup#3052 and KhronosGroup#3077. Should fix KhronosGroup#3076 conclusively.
kenrussell
added a commit
that referenced
this pull request
Jun 9, 2020
The earliest version of this code, which was seemingly stable, made the determination of whether to use a local or remote URL cor cross-origin images up front. Network timeouts from machines that deliberately aren't connected to the open Internet can't be relied upon as a fallback mechanism. Change the code back to examine the test's URL and choose whether to load local or remote images based on that. Also attempt to make runningOnLocalhost more robust to IPv6 loopback addresses. Follow-on to #3052 and #3077. See http://crbug.com/1082525 for more background. Should fix #3076 conclusively. Note that #3097 was proposed as an alternative solution for this problem and may still be considered in the future if this change destabilizes some browsers' CI systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ocal on localhost.
Fixes regressions from #3032: