integer-cubemap-specification-order-bug.html: add more test cases #2806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes this test more likely to catch the intended driver bug. These tests were generated by shuffling the initialization order thousands of times and picking specifically the cases that failed on the affected driver. crbug.com/905003
kdashg
approved these changes
Feb 12, 2019
Contributor
|
Crazy, thanks! |
Contributor
Author
|
Considered adding more test cases here, to wriggle around more workaround attempts. But after thinking about this more, it's just too hard to even work around. I'm going to merge these just to make the test a little more robust, but I've sent this bug to NVIDIA (again) so hopefully they can take care of it in their driver instead. |
kenrussell
added a commit
to kenrussell/WebGL
that referenced
this pull request
Jul 27, 2020
Incorporate fix from KhronosGroup#2327, which never made it into the 2.0.0 snapshot. This test was substantially rewritten on top-of-tree in KhronosGroup#2806.
kenrussell
added a commit
that referenced
this pull request
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes this test more likely to catch the intended driver bug in the presence of attempted workarounds. (This caught that a few of my attempts at workarounds were not good enough. The eventual fix is (probably) to just preallocate POSITIVE_X, level 0 before everything else.)
These tests were generated by shuffling the initialization order
thousands of times and picking specifically the cases that failed
on the affected driver.
https://crbug.com/905003