Prepare tests for landing texImageSource & GL_RGB10_A2 support. #2386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splitting part of the KhronosGroup#2375 to allow landing https://crrev.com/2821363003/ before landing the KhronosGroup#2375. This is related to KhronosGroup#2274: GL_RGB10_A2 and texImageSource variants of tex*Image*
Contributor
Author
|
@kenrussell , @zhenyao PTAL. Here, splitting these changes: The plan is is then to:
Thanks. |
Member
|
LGTM In my opinion it would also have been OK to mark these two tests as failing temporarily. Regardless, merging now. |
kenrussell
added a commit
to kenrussell/WebGL
that referenced
this pull request
Jul 27, 2020
These tests were invalidated in KhronosGroup#2386. In order to allow both old and new implementations to pass these tests, and to minimize complexity in the 2.0.0 conformance snapshot, simply remove the now-invalid tests.
kenrussell
added a commit
that referenced
this pull request
Jul 27, 2020
These tests were invalidated in #2386. In order to allow both old and new implementations to pass these tests, and to minimize complexity in the 2.0.0 conformance snapshot, simply remove the now-invalid tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting part of the #2375 to
allow landing https://crrev.com/2821363003/ before landing the
#2375.
This is related to #2274: GL_RGB10_A2 and texImageSource variants of texImage