Skip to content

Update CMake min to 3.28 - #613

Open
jpr42 wants to merge 3 commits into
KhronosGroup:mainfrom
jpr42:dev-cmake-328
Open

Update CMake min to 3.28#613
jpr42 wants to merge 3 commits into
KhronosGroup:mainfrom
jpr42:dev-cmake-328

Conversation

@jpr42

@jpr42 jpr42 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Ubuntu 24.04 LTS (noble) packages cmake 3.28.3, only the 2 latest LTS releases are supported,
requiring 3.28 keeps compatibility with all currently supported Ubuntu LTS versions.

Utilize new block() functionality instead of function

Utilize VERIFY_INTERFACE_HEADER_SETS to ensure header files can compile correctly on their own. (Test code only).

Ubuntu 24.04 LTS (noble) packages cmake 3.28.3, only the 2 latest LTS releases are supported,
requiring 3.28 keeps compatibility with all currently supported Ubuntu LTS versions.

Utilize new block() functionality instead of function

Utilize VERIFY_INTERFACE_HEADER_SETS to ensure header files can compile correctly on their own. (Test code only).
@CLAassistant

CLAassistant commented Jul 7, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Comment thread tests/CMakeLists.txt Outdated
@jpr42
jpr42 requested a review from M2-TE July 13, 2026 20:11

@M2-TE M2-TE left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should already be good in its current state.
Still, I've added two minor comments below.

Another thing: The windows clang runners only seem to use the latest default cmake, not [ '3.22.1', 'latest'] like the others. Is this intentional?

Comment thread tests/CMakeLists.txt Outdated
Comment thread tests/CMakeLists.txt Outdated
@jpr42

jpr42 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Another thing: The windows clang runners only seem to use the latest default cmake, not [ '3.22.1', 'latest'] like the others. Is this intentional?

Not sure. I fixed it regardless.

@M2-TE

M2-TE commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Looks good. Got nothing else to add!

@charles-lunarg charles-lunarg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow it felt like CMake 3.28 released last week... it came out at the tail end of 2023.

Looking through various Vulkan repo's, the min cmake version is 3.22.1, which stems from an update to spirv-tools that occured in Jan 2025.

I am going to approve this PR because it is in a good state, and moves the baseline forward, but I am holding off merging until I can get a confirmation that it is too soon to update. Merging this will likely require dependent repo's to update their CMake version, so in a sense this triggers a small cascade of subsequent PR's in about a dozen repo's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants