-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo #614
Merged
Merged
Fix typo #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmlueck
reviewed
Sep 6, 2024
adoc/code/usm_device.cpp
Outdated
Comment on lines
12
to
13
// Allocate device global memory bound to the device and context associated | ||
// with the queue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// Allocate device global memory bound to the device and context associated | |
// with the queue | |
// Allocate device USM, using the device and context associated with the queue |
We should use consistent terminology. Elsewhere in the spec we call this "device USM".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change made.
gmlueck
approved these changes
Sep 6, 2024
Merging as editorial |
gmlueck
added a commit
to gmlueck/SYCL-Docs
that referenced
this pull request
Sep 8, 2024
Fix typo Cherry pick KhronosGroup#614 from main
keryell
pushed a commit
that referenced
this pull request
Sep 10, 2024
gmlueck
added a commit
to gmlueck/SYCL-Docs
that referenced
this pull request
Sep 14, 2024
Cherry pick KhronosGroup#614 from main (cherry picked from commit 781e4fe)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allocation is for device USM, not shared USM.