Disallow repeated swizzle element in assignment #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously decided that assignment to a `__writeable_swizzle__` should have a constraint that the lhs does not have any repeated swizzle elements. Thus, something like this is disallowed: ``` vec<int, 2> x; myvec.swizzle<1,1>() = x; ``` We did this because the result would depend on the order in which the assignments occurred, and we think that some compilers will not handle this case well. However, we neglected to add the same constraint to other assignment-like swizzle operations. This commit adds a similar constraint, which disallows all of the following cases also, where the `__writeable_swizzle__` has repeated elements: ``` myvec.swizzle<1,1>().load(off, p); myvec.swizzle<1,1>() += x; myvec.swizzle<1,1>()++; ++(myvec.swizzle<1,1>()); ```
AerialMantis
approved these changes
Jul 18, 2024
TApplencourt
approved these changes
Jul 18, 2024
tomdeakin
approved these changes
Jul 24, 2024
keryell
pushed a commit
that referenced
this pull request
Sep 10, 2024
Disallow repeated swizzle element in assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously decided that assignment to a
__writeable_swizzle__should have a constraint that the lhs does not have any repeated swizzle elements. Thus, something like this is disallowed:We did this because the result would depend on the order in which the assignments occurred, and we think that some compilers will not handle this case well.
However, we neglected to add the same constraint to other assignment-like swizzle operations. This commit adds a similar constraint, which disallows all of the following cases also, where the
__writeable_swizzle__has repeated elements: