-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix prvalue to xvalue conversion address space assignment #464
Merged
gmlueck
merged 4 commits into
KhronosGroup:SYCL-2020/master
from
Naghasan:prvalue-promotion-errata
Dec 7, 2023
Merged
Fix prvalue to xvalue conversion address space assignment #464
gmlueck
merged 4 commits into
KhronosGroup:SYCL-2020/master
from
Naghasan:prvalue-promotion-errata
Dec 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victor-eds
approved these changes
Sep 21, 2023
keryell
reviewed
Oct 5, 2023
@Naghasan ping! |
Naghasan
force-pushed
the
prvalue-promotion-errata
branch
from
November 9, 2023 19:34
ebfbd65
to
e34ce9e
Compare
@keryell I extended the initial text to also account for the context in which prvalue to xvalue is taking place. I find it a bit "hand wavy" but still acceptable. The new commit also account for this: void bar() {
static constexpr const int& foo = 42;
} |
The common address deduction rules assumed prvalue-to-xvalue conversion can only happens inside a function. The patch aligns the rules to match declaration rules.
keryell
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
… during prvalue-to-xvalue conversion
Naghasan
force-pushed
the
prvalue-promotion-errata
branch
from
November 30, 2023 17:25
e34ce9e
to
4e5fafe
Compare
Resolved conflict: rebased to head and ran reflow |
gmlueck
reviewed
Dec 7, 2023
gmlueck
reviewed
Dec 7, 2023
Co-authored-by: Greg Lueck <gregory.m.lueck@intel.com>
Signed-off-by: Victor Lomuller <victor@codeplay.com>
gmlueck
approved these changes
Dec 7, 2023
keryell
pushed a commit
that referenced
this pull request
Sep 10, 2024
Fix prvalue to xvalue conversion address space assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The common address deduction rules assumed prvalue-to-xvalue conversion can only happens inside a function.
The patch aligns the rules to match declaration rules.
It is a bit of a corner case, but the spec treated all 3 conversions bellow in the same way.