Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to "denorms are flushed to zero" #445

Merged

Conversation

gmlueck
Copy link
Contributor

@gmlueck gmlueck commented Jul 21, 2023

This appears to be an error from when we transcribed these function definitions from OpenCL. There is no mode called "denorms are flushed to zero" in SYCL. In OpenCL, this corresponds to the compiler flag "-cl-denorms-are-zero", but SYCL does not define any compiler flags.

Vendors could define a compiler flag like this if they want. In this case, it would be the vendor's responsibility to document the effect.

Closes internal issue 657.

@gmlueck
Copy link
Contributor Author

gmlueck commented Jul 21, 2023

IMPORTANT!

This is currently a "stacked" PR on top of #440. Once #440 is merged, this PR should be retargeted to the "SYCL-2020/master" branch.

This appears to be an error from when we transcribed these function
definitions from OpenCL.  There is no mode called "denorms are flushed
to zero" in SYCL.  In OpenCL, this corresponds to the compiler flag
"-cl-denorms-are-zero", but SYCL does not define any compiler flags.

Vendors could define a compiler flag like this if they want.  In this
case, it would be the vendor's responsibility to document the effect.

Closes internal issue 657.
@gmlueck gmlueck force-pushed the gmlueck/rm-denorms-flushed branch from d112f37 to d48f575 Compare July 21, 2023 21:25
Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@gmlueck gmlueck marked this pull request as draft August 24, 2023 21:01
@gmlueck gmlueck changed the base branch from gmlueck/gentype-funcs-v2 to SYCL-2020/master September 7, 2023 21:20
@gmlueck gmlueck marked this pull request as ready for review September 7, 2023 21:20
@tomdeakin
Copy link
Contributor

Ready to merge.

@gmlueck gmlueck merged commit 71e1901 into KhronosGroup:SYCL-2020/master Sep 14, 2023
1 check passed
@gmlueck gmlueck deleted the gmlueck/rm-denorms-flushed branch November 10, 2023 21:37
keryell pushed a commit that referenced this pull request Sep 10, 2024
Remove reference to "denorms are flushed to zero"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants