Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change return type for "abs_diff" #441

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Change return type for "abs_diff" #441

merged 1 commit into from
Aug 24, 2023

Conversation

gmlueck
Copy link
Contributor

@gmlueck gmlueck commented Jul 21, 2023

Change abs_diff so that its return type is the same as the type of its parameters. This makes the signature consistent with abs.

Closes internal issue 655.

@gmlueck
Copy link
Contributor Author

gmlueck commented Jul 21, 2023

IMPORTANT!

This is currently a "stacked" PR on top of #440. Once #440 is merged, this PR should be retargeted to the "SYCL-2020/master" branch.

@gmlueck
Change return type for "abs_diff"
bcf0202 
Change `abs_diff` so that its return type is the same as the type of
its parameters.  This makes the signature consistent with `abs`.

Closes internal issue 655.
keryell
keryell approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@keryell keryell merged commit fa63259 into KhronosGroup:gmlueck/gentype-funcs-v2 Aug 24, 2023
1 check passed
@gmlueck
Copy link
Contributor Author

gmlueck commented Aug 24, 2023

Hi @keryell,

I think this PR should not have been merged yet because it is "stacked" on top of #440. Merging it just merges it to my private branch. We should wait for #440 to be merged, then I'll retarget these PRs to the "SYCL-2020/master" branch. Once that happens, we can merge them.

I converted the remaining "stacked" PRs to draft status for now to prevent them from being merged.

@keryell
Copy link
Member

keryell commented Aug 24, 2023

Oops. I merged this by error. :-(
@gmlueck can you remove this commit from https://github.com/KhronosGroup/SYCL-Docs/tree/gmlueck/gentype-funcs-v2 and reopen the PR, probably requiring some dummy commit on the source branch?
Sorry for the mess...

@gmlueck
Copy link
Contributor Author

gmlueck commented Aug 24, 2023

Yes, I will fix it up tomorrow.

@gmlueck gmlueck deleted the gmlueck/abs-diff branch August 25, 2023 20:22
@gmlueck gmlueck restored the gmlueck/abs-diff branch August 25, 2023 20:23
@gmlueck
Copy link
Contributor Author

gmlueck commented Aug 25, 2023

I couldn't find a way to reopen a PR that is already merged, so I created a new PR instead: #458. Could those people who approved this PR also approve #458?

I removed the incorrectly merged commits from https://github.com/KhronosGroup/SYCL-Docs/tree/gmlueck/gentype-funcs-v2.

@gmlueck gmlueck deleted the gmlueck/abs-diff branch November 10, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keryell keryell keryell approved these changes

@TApplencourt TApplencourt TApplencourt approved these changes

@AerialMantis AerialMantis AerialMantis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gmlueck @keryell @TApplencourt @AerialMantis