Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefetch_host #280

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TApplencourt
Copy link
Contributor

This is PR who follows up on #277, and adds some prefetch_host API.

[ I don't think the addition of prefetch_host API was discussed by the committee, so sorry for opening the PR now. It's just that I got some free time and didn't want to forget about this ]

We have prefetch that allows the runtime to transfer data from the host to the device, but we are missing the reverse, transferring data from the device to the host.
Cuda and OpenCL have the API. As usual ( :) ) HipSYCL have already an extension for this: https://github.com/illuhad/hipSYCL/blob/develop/doc/extensions.md#hipsycl_ext_prefetch_host #9

@gmlueck
Copy link
Contributor

gmlueck commented Aug 29, 2022

Should this be a proposed PR for SYCL-Next instead? This repo is for fixes to SYCL 2020.

@TApplencourt
Copy link
Contributor Author

TApplencourt commented Aug 29, 2022

I can do that. This adds a new API call so that it may be better in SYCL next indeed.
Should I make the PR to a new SYCLnext branch that I create?

@gmlueck
Copy link
Contributor

gmlueck commented Aug 30, 2022

Should I make the PR to a new SYCLnext branch that I create?

There is already a SYCL-Next branch on the internal GitLab repo. It should be an MR there.

@TApplencourt
Copy link
Contributor Author

Closing it, will move to internal

@TApplencourt
Copy link
Contributor Author

I think it's still a good idea (just got beaten by that today). Need to check if I did follow up and opened a issue on the internal

@TApplencourt
Copy link
Contributor Author

TApplencourt commented Sep 5, 2024

Opened here https://gitlab.khronos.org/sycl/Specification/-/merge_requests/729 , need to be ported.

Question:

  • Only free function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants