Skip to content

Commit

Permalink
Fix defs of "fast_length" and "fast_normalize"
Browse files Browse the repository at this point in the history
It appears that these function definitions were incorrectly
transcribed from OpenCL.  In OpenCL, they rely on the half-precision
versions of `sqrt` and `rsqrt`, not the overloads that take `half`
types.

Closes internal issue 656.
  • Loading branch information
gmlueck committed Jul 21, 2023
1 parent b07970b commit 98dbf7c
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions adoc/chapters/programming_interface.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -25619,7 +25619,7 @@ _Constraints:_ Available only if [code]#GeoFloat# is a _float geometric type_
as defined above.

_Returns:_ The length of vector [code]#p# computed as:
[code]#+sqrt((half)(pow(p[0],2) + pow(p[1],2) + ...))+#.
[code]#+half_precision::sqrt((pow(p[0],2) + pow(p[1],2) + ...))+#.

The return type is [code]#GeoFloat# if the input type is scalar. Otherwise,
the return type is [code]#GeoFloat::value_type#.
Expand All @@ -25639,7 +25639,8 @@ _Constraints:_ Available only if [code]#GeoFloat# is a _float geometric type_
as defined above.

_Returns:_ A vector in the same direction as [code]#p# but with a length of 1
computed as [code]#+p*rsqrt((half)(pow(p[0],2) + pow(p[1],2) + ... ))+#.
computed as
[code]#+p * half_precision::rsqrt((pow(p[0],2) + pow(p[1],2) + ... ))+#.

The result shall be within 8192 ulps error from the infinitely precise result
of
Expand Down

0 comments on commit 98dbf7c

Please sign in to comment.