Skip to content

Commit

Permalink
Merge pull request #615 from gmlueck/gmlueck/deprecate_fallback
Browse files Browse the repository at this point in the history
Deprecate fallback/secondary queue.
  • Loading branch information
gmlueck authored Sep 8, 2024
2 parents 93170a2 + 1162d24 commit 4f22b6a
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 2 deletions.
2 changes: 2 additions & 0 deletions adoc/chapters/architecture.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -1518,6 +1518,8 @@ queue.
The situations where a SYCL runtime may be able to achieve this asynchronous
fall-back is implementation-defined.

This feature is deprecated in SYCL NEXT.

=== Scheduling of kernels and data movement

A <<command-group-function-object>> takes a reference to a command group
Expand Down
6 changes: 5 additions & 1 deletion adoc/chapters/programming_interface.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -3230,7 +3230,8 @@ a@
----
template <typename T> event submit(T cgf, queue& secondaryQueue)
----
a@ Submit a <<command-group-function-object>> to the queue, in order to be scheduled
a@ Deprecated in SYCL NEXT.
Submit a <<command-group-function-object>> to the queue, in order to be scheduled
for execution on the device. On a kernel error, this <<command-group-function-object>>
is then scheduled for execution on the secondary queue. Returns an
event, which corresponds to the queue the <<command-group-function-object>>
Expand Down Expand Up @@ -13382,6 +13383,7 @@ fall-back from primary to secondary queue are unspecified in the specification.
Even if a command group is run on the secondary queue, the requirement that host
code within the command group is executed exactly once remains, regardless of
whether the fallback queue is used for execution.
The fallback queue feature is deprecated in SYCL NEXT.

The command group [code]#handler# class provides the interface for all of the
member functions that are able to be executed inside the command group scope,
Expand Down Expand Up @@ -16577,6 +16579,8 @@ context will be used and if the context was also constructed without an
The <<command-group-function-object>> event returned by that function will be
relevant to the queue where the kernel has been enqueued.

The secondary queue feature is deprecated in SYCL NEXT.

Below is an example of catching a SYCL [code]#exception# and printing out the
error message.

Expand Down
6 changes: 5 additions & 1 deletion adoc/chapters/what_changed.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@
[[cha:what-changed-from]]
= What has changed from previous versions

[[sec:what-changed-between]]
== What has changed from SYCL 2020 to SYCL NEXT

* The overload with a fallback/secondary queue parameter of the
[code]#submit()# member function of [code]#sycl::queue# was deprecated.

== What has changed from SYCL 1.2.1 to SYCL 2020

The SYCL runtime moved from namespace [code]#cl::sycl# provided by
Expand Down
1 change: 1 addition & 0 deletions adoc/headers/queue.h
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ class queue {

template <typename T> event submit(T cgf);

// Deprecated in SYCL NEXT.
template <typename T> event submit(T cgf, const queue& secondaryQueue);

void wait();
Expand Down

0 comments on commit 4f22b6a

Please sign in to comment.