Fix SYCL 2020 accessor::value_type tests #395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 10, 2022 07:47
Section 4.7.6.9.1 changes value_type const-ness if accessor read-only. Implementation was changed but test wasn't.
host_image, image_array, and image targets all removed form the specification in favour of specialised accessors (https://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#sec:what-changed-between) These tests now pass. check_image_accessor_api_type commented out for now.
andylshort
requested review from
ProGTX,
bader,
illuhad and
keryell
as code owners
|
|
|
@andylshort, please, fix code formatting. |
|
@bader Yes, the dpcpp compiler will need to be brought forward at least to commit intel/llvm@227614c where accessor::value_type was made SYCL 2020 compliant. If there's any more issues with formatting, please do let me know! |
|
Compiler version uplifting must be done from a local branch, so I pushed you changes + DPC++ version uplift to #398. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The accessor class's value_type member was updated recently to change its "const"-ness when in read-only mode (intel/llvm#7096) for SYCL 2020 compliance as defined in Section 4.7.6.9.1 The tests were not updated to reflect this change.
This patch specifically addresses the
accessor_api_buffer_coretest in the accessor_legacy directory and the error:In addition to the changes to accessor_api_common_all.h, it was necessary to resolve issues with accessor_api_image_common.h as there were tests in there for invalid targets. host_image, image, and image_array have been removed from the SYCL 2020 specification in favour of respectively specialised accessors. It was decided to simply remove these from the tests for that reason due to this being legacy testing.