spirv-val: Add missing NonSemantic.Shader.DebugInfo.100 #5846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencer-lunarg
commented
Oct 9, 2024
spencer-lunarg
commented
Oct 9, 2024
spencer-lunarg
commented
Oct 9, 2024
spencer-lunarg
commented
Oct 9, 2024
spencer-lunarg
commented
Oct 9, 2024
|
@alan-baker I see it is failing CI in https://btx.cloud.google.com/invocations/36895f7b-5b6d-4dac-8efe-c9225e6f04d6/targets/graphics_shader_compiler%2Fspirv-tools%2Fshaderc-smoketest%2Fpresubmit/log but these errors make no sense, locally it runs fine and all the errors are around not being able to run |
|
Can you rebase on main? SPIRV-Headers merged a PR to remove aliases as separate grammar entries. The tooling is up-to-date on main. |
spencer-lunarg
force-pushed
the
spencer-lunarg-debug-22
branch
from
b334b52 to
66815b5
Compare
alan-baker
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing coverage for NonSemantic.Shader.DebugInfo.100 where it was different from
OpenCL.DebugInfo.100(Created 2 commits prior to reduce the copy-and-pasting in the tests)