Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SPV_INTEL_fpga_cluster_attributes extension #821

Merged

Conversation

MrSidims
Copy link
Contributor

This extension adds a decoration, applicable on functions, that
statically-scheduled clusters should handle stalls using a
stall-enable signal to freeze computation within the cluster.

Spec: KhronosGroup/SPIRV-Registry#85

Signed-off-by: Dmitry Sidorov dmitry.sidorov@intel.com

@MrSidims
Copy link
Contributor Author

MrSidims commented Nov 20, 2020

  • Propagate to SPIR-V Headers

@MrSidims MrSidims force-pushed the private/MrSidims/StallEnable branch from dd65992 to 0b07e73 Compare November 23, 2020 07:30
@MrSidims MrSidims closed this Nov 24, 2020
@MrSidims MrSidims reopened this Nov 24, 2020
@MrSidims MrSidims force-pushed the private/MrSidims/StallEnable branch from 0b07e73 to ca11858 Compare November 25, 2020 12:03
@MrSidims
Copy link
Contributor Author

@AlexeySotkin @AlexeySachkov please take a look

Copy link
Contributor

@AlexeySotkin AlexeySotkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment. Overall LGTM. Thanks!

@MrSidims MrSidims force-pushed the private/MrSidims/StallEnable branch from ca11858 to 7f2d2cb Compare November 30, 2020 13:22
@AlexeySotkin
Copy link
Contributor

@mlychkov please take a look.

@MrSidims MrSidims force-pushed the private/MrSidims/StallEnable branch from 7f2d2cb to 0714ccc Compare December 1, 2020 10:10
This extension adds a decoration, applicable on functions, that
statically-scheduled clusters should handle stalls using a
stall-enable signal to freeze computation within the cluster.

Spec: KhronosGroup/SPIRV-Registry#85

Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com>
@MrSidims MrSidims force-pushed the private/MrSidims/StallEnable branch from 0714ccc to fb0c844 Compare December 2, 2020 10:46
@AlexeySotkin AlexeySotkin merged commit a506cbc into KhronosGroup:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants