-
Notifications
You must be signed in to change notification settings - Fork 243
Add support for toolchain compilation with LLVM_LINK_LLVM_DYLIB option #1543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The purpose of this PR is to break a circular dependency between GenXIntrinsics and llvm libraries to allow building of llvm with shared library configuration. This PR is a first step for this purpose and the follow up PR in llvm branch will use the results of this PR to complete the configuration change The failing tests are :
|
@fineg74, could you please simply merge |
@AlexeySachkov I merged the latest main and pushed into PR. Do I need to resubmit the PR ? |
Paradoxically, our builds with The change seems like a workaround for an issue in intel/llvm that causes regressions for other downstream users. Looking at intel/llvm#6413, I think the patch should have been applied there, or at least limited to that particular build scenario and not all builds with if(INTEL_LLVM AND LLVM_LINK_LLVM_DYLIB)
add_llvm_library(LLVMSPIRVLib STATIC DISABLE_LLVM_LINK_LLVM_DYLIB ...)
else()
add_llvm_library(LLVMSPIRVLib ...)
endif() |
Move the LLVM components to LINK_COMPONENTS because the DEPENDS list has the same semantics as add_dependencies(). In this case it doesn't include the LLVM components when calling the linker. It's almost complete revert of #1543
Move the LLVM components to LINK_COMPONENTS because the DEPENDS list has the same semantics as add_dependencies(). In this case it doesn't include the LLVM components when calling the linker. It's almost complete revert of KhronosGroup#1543
Move the LLVM components to LINK_COMPONENTS because the DEPENDS list has the same semantics as add_dependencies(). In this case it doesn't include the LLVM components when calling the linker. It's almost complete revert of #1543 Co-authored-by: Tulio Magno Quites Machado Filho <tuliom@quites.com.br>
No description provided.