Spv qcom image processing3#596
Conversation
|
|
wooyoungqcom
force-pushed
the
spv-qcom-image-processing3
branch
from
ecb0849 to
f5b530f
Compare
|
Something is wrong with your latest rebuild. It is no longer including the new enum when it tests the build. |
|
I am having a CLA issue. Maybe that is the reason the server refuses to pull in the patch? |
wooyoungqcom
force-pushed
the
spv-qcom-image-processing3
branch
from
f5b530f to
f559f31
Compare
| { "kind" : "IdRef", "name" : "Sampled Image" }, | ||
| { "kind" : "IdRef", "name" : "Coordinate" }, | ||
| { "kind" : "IdRef", "name" : "Component" }, | ||
| { "kind" : "LiteralInteger", "name" : "Mode" }, |
There was a problem hiding this comment.
I think this should be:
| { "kind" : "LiteralInteger", "name" : "Mode" }, | |
| { "kind" : "GatherModes", "name" : "Mode" }, |
There was a problem hiding this comment.
Separately, looking at the spec again. The extension claims this should be an id.
There was a problem hiding this comment.
It should have been GatherModes. Also, while I was fixing it, I realized I missed adding a couple of files to the change set. That mistake also has been fixed. Thank you so much !!!
There was a problem hiding this comment.
We made the changes quite a while ago, and I was confused with the back-up changes I made.
The intention was we use for "Mode".
I made the fix and I also updated the spec accordingly.
wooyoungqcom
force-pushed
the
spv-qcom-image-processing3
branch
from
f559f31 to
b3c106a
Compare
wooyoungqcom
force-pushed
the
spv-qcom-image-processing3
branch
from
b3c106a to
c07e080
Compare
3 participants
No description provided.