Make C++ operator overload for enums not happen for HLSL#386
Make C++ operator overload for enums not happen for HLSL#386devshgraphicsprogramming wants to merge 18 commits into
Conversation
|
|
dneto0
left a comment
There was a problem hiding this comment.
It would be better to generate a new file specific to HLSL.
Given the direction HLSL is heading, I'll eventually expect the C++11 file to work without issues. |
|
Hi @devshgraphicsprogramming, just checking in to ensure you saw the review comment above and aren't waiting on anything from us. Thanks! |
And I responded, wonder if you saw that. |
I think so, do you mean your response:
If this is the case, is this PR needed? Thanks! |
The HLSL 202x project has not committed to this feature, nobody knows if and when they'll add operator overloads. Its probably contingent on proposal 0006 and thats probably years away. A PR is needed either with this or HLSL specific headers which is what I suggested in #385 but got no answer. |
|
Let's do this by generating a specific file for HLSL, as @dneto suggested above. This way the C++ files remain unchanged and if any other changes are needed for HLSL they can be easily added. @devshgraphicsprogramming can you please update this PR to generate an HLSL-specific file? Thanks! |
…into header_4_hlsl
…into header_4_hlsl
This allows for inclusion of the headers in HLSL2021 shaders.
Helps with maintenance of large headers of SPIR-V intrinsics (don't need to type out the opcodes by hand).
Fixes #385