Skip to content

Make C++ operator overload for enums not happen for HLSL#386

Open
devshgraphicsprogramming wants to merge 18 commits into
KhronosGroup:mainfrom
Devsh-Graphics-Programming:header_4_hlsl
Open

Make C++ operator overload for enums not happen for HLSL#386
devshgraphicsprogramming wants to merge 18 commits into
KhronosGroup:mainfrom
Devsh-Graphics-Programming:header_4_hlsl

Conversation

@devshgraphicsprogramming
Copy link
Copy Markdown

This allows for inclusion of the headers in HLSL2021 shaders.

Helps with maintenance of large headers of SPIR-V intrinsics (don't need to type out the opcodes by hand).

Fixes #385

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 20, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 5 committers have signed the CLA.

✅ Przemog1
✅ devshgraphicsprogramming
❌ deprilula28
❌ keptsecret
❌ AnastaZIuk
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown
Contributor

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to generate a new file specific to HLSL.

@devshgraphicsprogramming
Copy link
Copy Markdown
Author

It would be better to generate a new file specific to HLSL.

Given the direction HLSL is heading, I'll eventually expect the C++11 file to work without issues.

@bashbaug
Copy link
Copy Markdown
Contributor

Hi @devshgraphicsprogramming, just checking in to ensure you saw the review comment above and aren't waiting on anything from us. Thanks!

@devshgraphicsprogramming
Copy link
Copy Markdown
Author

Hi @devshgraphicsprogramming, just checking in to ensure you saw the review comment above and aren't waiting on anything from us. Thanks!

And I responded, wonder if you saw that.

@bashbaug
Copy link
Copy Markdown
Contributor

bashbaug commented Dec 5, 2023

And I responded, wonder if you saw that.

I think so, do you mean your response:

I'll eventually expect the C++11 file to work without issues.

If this is the case, is this PR needed? Thanks!

@devshgraphicsprogramming
Copy link
Copy Markdown
Author

And I responded, wonder if you saw that.

I think so, do you mean your response:

I'll eventually expect the C++11 file to work without issues.

If this is the case, is this PR needed? Thanks!

The HLSL 202x project has not committed to this feature, nobody knows if and when they'll add operator overloads. Its probably contingent on proposal 0006 and thats probably years away.

A PR is needed either with this or HLSL specific headers which is what I suggested in #385 but got no answer.

@bashbaug
Copy link
Copy Markdown
Contributor

bashbaug commented Jan 2, 2024

Let's do this by generating a specific file for HLSL, as @dneto suggested above. This way the C++ files remain unchanged and if any other changes are needed for HLSL they can be easily added.

@devshgraphicsprogramming can you please update this PR to generate an HLSL-specific file? Thanks!

deprilula28 and others added 16 commits January 3, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Surround C++ operator overloads in hpp and hpp11 with an #ifndef SPV_DISABLE_ENUM_OPERATORS

8 participants