Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add KHR extensions to OpenCL registry #101

Merged
merged 3 commits into from
Oct 5, 2021

Conversation

bashbaug
Copy link
Contributor

See internal issue 188.

Updates scripts and the extension registry to include KHR extensions (mostly new) in addition to EXT and vendor-specific extensions (existing).

Summary of the changes are:

  1. I modified the script to generate separate unnumbered, alphabetized lists for KHR extensions and non-KHR extensions instead of a single ordered list based on the extension number for (primarily non-KHR) extensions. This was the biggest change (but not too bad, the script is very short).
  2. I modified the registry webpage to include both extension lists instead of only the primarily-non-KHR extension list.
  3. I added all KHR extensions to registry.py with links into the extension spec.
  4. A few minor changes to Makefiles or other supporting scripts.

Needs working group sign-off before merging.

@bashbaug bashbaug force-pushed the add-khr-extensions-to-registry branch from 2beb575 to 2a42ebc Compare August 25, 2021 20:33
Copy link
Contributor

@alycm alycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm not setup to view the PHP locally.

@bashbaug bashbaug force-pushed the add-khr-extensions-to-registry branch from 2a42ebc to be0d89b Compare October 5, 2021 18:24
@bashbaug
Copy link
Contributor Author

bashbaug commented Oct 5, 2021

Merging as we discussed in the October 5th teleconference.

@bashbaug bashbaug merged commit 25c4e9d into KhronosGroup:main Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants